Implement unregisterProtocolHandler()

Complete unregisterProtocolHandler() implementation.

BUG=392016
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282960

[pals, 2014-07-04 09:34:30]

This patch depends on https://codereview.chromium.org/294023010/ and should land
after that CL.

[lgombos, 2014-07-07 23:02:57]

On 2014/07/04 09:34:30, sanjoy.pal wrote:
> This patch depends on https://codereview.chromium.org/294023010/ and should
land
> after that CL.

Can you or Gyuyoung create a bug for this work - especially that we will have
more than one patches.

[gyuyoung-inactive, 2014-07-08 01:24:34]

On 2014/07/07 23:02:57, lgombos wrote:
> On 2014/07/04 09:34:30, sanjoy.pal wrote:
> > This patch depends on https://codereview.chromium.org/294023010/ and should
> land
> > after that CL.
> 
> Can you or Gyuyoung create a bug for this work - especially that we will have
> more than one patches.

I file a bug - https://code.google.com/p/chromium/issues/detail?id=392016

[jochen (gone - plz use gerrit), 2014-07-10 11:34:34]

can you merge the two CLs?

[pals, 2014-07-10 12:59:16]

On 2014/07/10 11:34:34, jochen wrote:
> can you merge the two CLs?

Merged gyuyoung's CL and

Added cevans for content/common/view_messages.h

PTAL.

[jochen (gone - plz use gerrit), 2014-07-11 09:39:11]

lgtm

https://codereview.chromium.org/368243009/diff/60001/chrome/browser/ui/browse...
File chrome/browser/ui/browser.cc (right):

https://codereview.chromium.org/368243009/diff/60001/chrome/browser/ui/browse...
chrome/browser/ui/browser.cc:1668: const std::string& protocol,
nit. please clang-format

[pals, 2014-07-11 11:25:19]

https://codereview.chromium.org/368243009/diff/60001/chrome/browser/ui/browse...
File chrome/browser/ui/browser.cc (right):

https://codereview.chromium.org/368243009/diff/60001/chrome/browser/ui/browse...
chrome/browser/ui/browser.cc:1668: const std::string& protocol,
On 2014/07/11 09:39:11, jochen wrote:
> nit. please clang-format

Done.

[kenrb, 2014-07-11 14:38:38]

ipc lgtm, with a somewhat unrelated comment.

https://codereview.chromium.org/368243009/diff/80001/chrome/browser/ui/browse...
File chrome/browser/ui/browser.cc (right):

https://codereview.chromium.org/368243009/diff/80001/chrome/browser/ui/browse...
chrome/browser/ui/browser.cc:1670: bool user_gesture) {
This appears to be an unused argument passed from the renderer process. Is this
going to be used in future or can it be removed?

[pals, 2014-07-11 15:07:59]

On 2014/07/11 14:38:38, kenrb wrote:
> ipc lgtm, with a somewhat unrelated comment.
> 
>
https://codereview.chromium.org/368243009/diff/80001/chrome/browser/ui/browse...
> File chrome/browser/ui/browser.cc (right):
> 
>
https://codereview.chromium.org/368243009/diff/80001/chrome/browser/ui/browse...
> chrome/browser/ui/browser.cc:1670: bool user_gesture) {
> This appears to be an unused argument passed from the renderer process. Is
this
> going to be used in future or can it be removed?

It will be useful if we want to have confirmation bubble from user while
un-registering the handler.

[kenrb, 2014-07-11 15:36:37]

On 2014/07/11 15:07:59, sanjoy.pal wrote:
> On 2014/07/11 14:38:38, kenrb wrote:
> > ipc lgtm, with a somewhat unrelated comment.
> > 
> >
>
https://codereview.chromium.org/368243009/diff/80001/chrome/browser/ui/browse...
> > File chrome/browser/ui/browser.cc (right):
> > 
> >
>
https://codereview.chromium.org/368243009/diff/80001/chrome/browser/ui/browse...
> > chrome/browser/ui/browser.cc:1670: bool user_gesture) {
> > This appears to be an unused argument passed from the renderer process. Is
> this
> > going to be used in future or can it be removed?
> 
> It will be useful if we want to have confirmation bubble from user while
> un-registering the handler.

Okay. It might be worth a comment to that effect so the next person who touches
this code doesn't remove it.

[pals, 2014-07-14 06:22:13]

The CQ bit was checked by sanjoy.pal@samsung.com

[commit-bot: I haz the power, 2014-07-14 06:22:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/368243009/120001

[commit-bot: I haz the power, 2014-07-14 07:05:52]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/28106)

[commit-bot: I haz the power, 2014-07-14 07:07:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-14 07:07:02]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/28115)

[pals, 2014-07-14 13:11:14]

The CQ bit was checked by sanjoy.pal@samsung.com

[commit-bot: I haz the power, 2014-07-14 13:12:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/368243009/140001

[commit-bot: I haz the power, 2014-07-14 16:30:26]

Change committed as 282960