Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 294023010: Implement unregisterProtocolHandler() for content layer (Closed)

Created:
6 years, 7 months ago by gyuyoung-inactive
Modified:
6 years, 5 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, miu+watch_chromium.org, nasko+codewatch_chromium.org, pals
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Implement unregisterProtocolHandler() for content layer The content layer needs to support unregisterProtocolHandler() as well as registerProtocolHandler(). BUG=392016

Patch Set 1 #

Patch Set 2 : WIP #

Total comments: 6

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -0 lines) Patch
M content/browser/web_contents/web_contents_impl.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 2 chunks +16 lines, -0 lines 1 comment Download
M content/common/view_messages.h View 1 2 1 chunk +6 lines, -0 lines 1 comment Download
M content/public/browser/web_contents_delegate.h View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
gyuyoung-inactive
Work in progress
6 years, 5 months ago (2014-07-04 09:17:01 UTC) #1
gyuyoung-inactive
6 years, 5 months ago (2014-07-04 09:40:29 UTC) #2
gyuyoung-inactive
Add jochen.
6 years, 5 months ago (2014-07-09 05:37:53 UTC) #3
jochen (gone - plz use gerrit)
https://codereview.chromium.org/294023010/diff/20001/content/browser/web_contents/web_contents_impl.cc File content/browser/web_contents/web_contents_impl.cc (right): https://codereview.chromium.org/294023010/diff/20001/content/browser/web_contents/web_contents_impl.cc#newcode2768 content/browser/web_contents/web_contents_impl.cc:2768: ChildProcessSecurityPolicyImpl* policy = please clang-format this https://codereview.chromium.org/294023010/diff/20001/content/public/browser/web_contents_delegate.h File content/public/browser/web_contents_delegate.h ...
6 years, 5 months ago (2014-07-09 09:12:56 UTC) #4
gyuyoung-inactive
https://codereview.chromium.org/294023010/diff/20001/content/browser/web_contents/web_contents_impl.cc File content/browser/web_contents/web_contents_impl.cc (right): https://codereview.chromium.org/294023010/diff/20001/content/browser/web_contents/web_contents_impl.cc#newcode2768 content/browser/web_contents/web_contents_impl.cc:2768: ChildProcessSecurityPolicyImpl* policy = On 2014/07/09 09:12:56, jochen wrote: > ...
6 years, 5 months ago (2014-07-09 09:32:16 UTC) #5
gyuyoung-inactive
On 2014/07/09 09:32:16, gyuyoung wrote: > https://codereview.chromium.org/294023010/diff/20001/content/browser/web_contents/web_contents_impl.cc > File content/browser/web_contents/web_contents_impl.cc (right): > > https://codereview.chromium.org/294023010/diff/20001/content/browser/web_contents/web_contents_impl.cc#newcode2768 > ...
6 years, 5 months ago (2014-07-09 16:05:02 UTC) #6
jochen (gone - plz use gerrit)
how can we test this? https://codereview.chromium.org/294023010/diff/60001/content/browser/web_contents/web_contents_impl.cc File content/browser/web_contents/web_contents_impl.cc (right): https://codereview.chromium.org/294023010/diff/60001/content/browser/web_contents/web_contents_impl.cc#newcode2752 content/browser/web_contents/web_contents_impl.cc:2752: delegate_->UnregisterProtocolHandler(this, protocol, url, user_gesture); ...
6 years, 5 months ago (2014-07-10 11:30:07 UTC) #7
gyuyoung-inactive
On 2014/07/10 11:30:07, jochen wrote: > how can we test this? > > https://codereview.chromium.org/294023010/diff/60001/content/browser/web_contents/web_contents_impl.cc > ...
6 years, 5 months ago (2014-07-10 16:12:30 UTC) #8
gyuyoung-inactive
6 years, 5 months ago (2014-07-12 01:06:28 UTC) #9
Message was sent while issue was closed. 
On 2014/07/10 16:12:30, gyuyoung wrote:
> On 2014/07/10 11:30:07, jochen wrote:
> > how can we test this?
> > 
> >
>
https://codereview.chromium.org/294023010/diff/60001/content/browser/web_cont...
> > File content/browser/web_contents/web_contents_impl.cc (right):
> > 
> >
>
https://codereview.chromium.org/294023010/diff/60001/content/browser/web_cont...
> > content/browser/web_contents/web_contents_impl.cc:2752:
> > delegate_->UnregisterProtocolHandler(this, protocol, url, user_gesture);
> > can you please implement this as well? (i.e.
> Browser::UnregisterProtocolHandler)
> > 
> >
>
https://codereview.chromium.org/294023010/diff/60001/content/common/view_mess...
> > File content/common/view_messages.h (right):
> > 
> >
>
https://codereview.chromium.org/294023010/diff/60001/content/common/view_mess...
> > content/common/view_messages.h:1498:
> > IPC_MESSAGE_ROUTED3(ViewHostMsg_UnregisterProtocolHandler,
> > you'll need an security review for this
> 
> This bug is consists of two CLs. This one and issue 368243009. However, as you
> commented, should I still solve your homework ?
> If so, let me take a look tomorrow. Now is time to go bed :)
> 
> https://codereview.chromium.org/368243009/#msg4

Issue 368243009 merged this CL. So, closed.

Powered by Google App Engine
This is Rietveld 408576698