Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 368243007: Reland of "Use address_data.h from upstream libaddressinput". (Closed)

Created:
6 years, 5 months ago by please use gerrit instead
Modified:
6 years, 5 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Reland of "Use address_data.h from upstream libaddressinput". This patch fixes autofill tests on Windows and relands https://src.chromium.org/viewvc/chrome?view=rev&revision=281192, which was reverted in https://src.chromium.org/viewvc/chrome?view=rev&revision=281226 BUG=389918 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281798

Patch Set 1 #

Patch Set 2 : Check size. #

Patch Set 3 : Update BUILD.gn, fix a test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1466 lines, -395 lines) Patch
M chrome/browser/ui/autofill/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_i18n_input.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/autofill/data_model_wrapper.cc View 4 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/ui/autofill/mock_address_validator.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/address_i18n.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_profile.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/libaddressinput/BUILD.gn View 1 2 5 chunks +13 lines, -3 lines 0 comments Download
A third_party/libaddressinput/chromium/addressinput_util.h View 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/libaddressinput/chromium/addressinput_util.cc View 1 2 1 chunk +75 lines, -0 lines 0 comments Download
A third_party/libaddressinput/chromium/addressinput_util_unittest.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_data.h View 2 chunks +44 lines, -56 lines 0 comments Download
A third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_formatter.h View 1 chunk +51 lines, -0 lines 0 comments Download
A third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_metadata.h View 1 chunk +38 lines, -0 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/src/address_data.cc View 2 chunks +103 lines, -100 lines 0 comments Download
A third_party/libaddressinput/chromium/cpp/src/address_formatter.cc View 1 chunk +190 lines, -0 lines 0 comments Download
A third_party/libaddressinput/chromium/cpp/src/address_metadata.cc View 1 chunk +70 lines, -0 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/src/address_validator.cc View 6 chunks +8 lines, -8 lines 0 comments Download
A third_party/libaddressinput/chromium/cpp/src/language.h View 1 chunk +49 lines, -0 lines 0 comments Download
A third_party/libaddressinput/chromium/cpp/src/language.cc View 1 chunk +102 lines, -0 lines 0 comments Download
A third_party/libaddressinput/chromium/cpp/src/util/cctype_tolower_equal.h View 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/libaddressinput/chromium/cpp/src/util/cctype_tolower_equal.cc View 1 1 chunk +44 lines, -0 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/test/address_data_test.cc View 1 chunk +153 lines, -167 lines 0 comments Download
A third_party/libaddressinput/chromium/cpp/test/address_formatter_test.cc View 1 chunk +201 lines, -0 lines 0 comments Download
A third_party/libaddressinput/chromium/cpp/test/address_metadata_test.cc View 1 chunk +68 lines, -0 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/test/address_validator_test.cc View 30 chunks +37 lines, -37 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/test/countryinfo_example_addresses_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A third_party/libaddressinput/chromium/cpp/test/language_test.cc View 1 chunk +62 lines, -0 lines 0 comments Download
M third_party/libaddressinput/libaddressinput.gyp View 5 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Evan Stade
lgtm
6 years, 5 months ago (2014-07-07 21:21:15 UTC) #1
please use gerrit instead
The CQ bit was checked by rouslan@chromium.org
6 years, 5 months ago (2014-07-08 00:00:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/368243007/40001
6 years, 5 months ago (2014-07-08 00:01:13 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-08 02:52:11 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-08 03:20:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/90505)
6 years, 5 months ago (2014-07-08 03:20:30 UTC) #6
please use gerrit instead
The CQ bit was checked by rouslan@chromium.org
6 years, 5 months ago (2014-07-08 16:48:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/368243007/40001
6 years, 5 months ago (2014-07-08 16:50:01 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 19:54:19 UTC) #9
Message was sent while issue was closed. 
Change committed as 281798

Powered by Google App Engine
This is Rietveld 408576698