third_party/libaddressinput/chromium/cpp/test/countryinfo_example_addresses_test.cc - Issue 368243007: Reland of "Use address_data.h from upstream libaddressinput".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libaddressinput/chromium/cpp/test/countryinfo_example_addresses_test.cc

Issue 368243007: Reland of "Use address_data.h from upstream libaddressinput". (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update BUILD.gn, fix a test. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/libaddressinput/chromium/cpp/test/address_validator_test.cc ('k') | third_party/libaddressinput/chromium/cpp/test/language_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/libaddressinput/chromium/cpp/test/countryinfo_example_addresses_test.cc

diff --git a/third_party/libaddressinput/chromium/cpp/test/countryinfo_example_addresses_test.cc b/third_party/libaddressinput/chromium/cpp/test/countryinfo_example_addresses_test.cc

index de0caab3ebcd2e58bf327bc7eeb0d32d98477314..4f083c3094f60b395ca4d0fbf465a3d1fa0e0df9 100644

--- a/third_party/libaddressinput/chromium/cpp/test/countryinfo_example_addresses_test.cc

+++ b/third_party/libaddressinput/chromium/cpp/test/countryinfo_example_addresses_test.cc

@@ -102,9 +102,9 @@ class ExampleAddressValidatorTest

if (!fields_json->GetStringValueForKey(street_key, &street_field))

break;

- address.address_lines.push_back(street_field);

+ address.address_line.push_back(street_field);

}

- address.country_code = country;

+ address.region_code = country;

fields_json->GetStringValueForKey("state", &address.administrative_area);

fields_json->GetStringValueForKey("city", &address.locality);

fields_json->GetStringValueForKey("locality", &address.dependent_locality);

@@ -181,7 +181,7 @@ class ExampleAddressValidatorTest

virtual void OnAddressValidationRulesLoaded(const std::string& country_code,

bool success) {

AddressData address_data;

- address_data.country_code = country_code;

+ address_data.region_code = country_code;

AddressValidator::Status status =

validator_->ValidateAddress(address_data, AddressProblemFilter(), NULL);

EXPECT_TRUE(success);