src/preparser.h - Issue 368053002: Stack overflow checkers are now compatible with ASAN's detect_stack_use_after_return mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/preparser.h

Issue 368053002: Stack overflow checkers are now compatible with ASAN's detect_stack_use_after_return mode. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/preparser.h

diff --git a/src/preparser.h b/src/preparser.h

index d6be902713dc578af4e0f1e854736508db7b70b3..d14393811d7e6767e68597a7edba74c94faabfc2 100644

--- a/src/preparser.h

+++ b/src/preparser.h

@@ -246,8 +246,7 @@ class ParserBase : public Traits {

INLINE(Token::Value Next()) {

if (stack_overflow_) return Token::ILLEGAL;

{

- int marker;

- if (reinterpret_cast<uintptr_t>(&marker) < stack_limit_) {

+ if (GetCurrentStackPosition() < stack_limit_) {

// Any further calls to Next or peek will return the illegal token.

// The current call must return the next token, which might already

// have been peek'ed.

« no previous file with comments | « src/isolate.cc ('k') | test/cctest/test-parsing.cc » ('j') | no next file with comments »