content/renderer/media/media_stream_audio_processor_unittest.cc - Issue 367923004: Turn audio ducking on by default on Windows again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_audio_processor_unittest.cc

Issue 367923004: Turn audio ducking on by default on Windows again. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase, update tests, logging and documentation Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/media_stream_audio_processor_unittest.cc

diff --git a/content/renderer/media/media_stream_audio_processor_unittest.cc b/content/renderer/media/media_stream_audio_processor_unittest.cc

index aede2ffb6668b39f5f03c9bf98bebe96e3adc955..267d1d2fc53567bf5d95c746b6f3710471b4bade 100644

--- a/content/renderer/media/media_stream_audio_processor_unittest.cc

+++ b/content/renderer/media/media_stream_audio_processor_unittest.cc

@@ -336,10 +336,7 @@ TEST_F(MediaStreamAudioProcessorTest, VerifyConstraints) {

}

EXPECT_FALSE(audio_constraints.NeedsAudioProcessing());

#if defined(OS_WIN)

- // TODO(tommi): Turn this back to EXPECT_TRUE on Windows when ducking issues

- // have been resolved.

- // Bugs: crbug/391414, crbug/391247.

- EXPECT_FALSE(audio_constraints.GetProperty(kMediaStreamAudioDucking));

+ EXPECT_TRUE(audio_constraints.GetProperty(kMediaStreamAudioDucking));

#else

EXPECT_FALSE(audio_constraints.GetProperty(kMediaStreamAudioDucking));

#endif