content/renderer/media/media_stream_audio_processor_options.cc - Issue 367923004: Turn audio ducking on by default on Windows again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_audio_processor_options.cc

Issue 367923004: Turn audio ducking on by default on Windows again. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase, update tests, logging and documentation Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/media_stream_audio_processor_options.cc

diff --git a/content/renderer/media/media_stream_audio_processor_options.cc b/content/renderer/media/media_stream_audio_processor_options.cc

index 53add13ba42053a0a8750f60d0061f49d1f5077e..d3299929056c0395a514ff5b128972af1b5b556e 100644

--- a/content/renderer/media/media_stream_audio_processor_options.cc

+++ b/content/renderer/media/media_stream_audio_processor_options.cc

@@ -62,10 +62,7 @@ struct {

{ MediaAudioConstraints::kGoogTypingNoiseDetection, true },

{ MediaAudioConstraints::kGoogExperimentalNoiseSuppression, false },

#if defined(OS_WIN)

- // TODO(tommi): Turn this back to |true| on Windows when ducking issues

- // have been resolved.

- // Bugs: crbug/391414, crbug/391247.

- { kMediaStreamAudioDucking, false },

+ { kMediaStreamAudioDucking, true },

#else

{ kMediaStreamAudioDucking, false },

#endif