Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Unified Diff: runtime/Dockerfile

Issue 367903008: Create a set of Dart dockerfiles (Closed) Base URL: https://github.com/dart-lang/dart_docker.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/Dockerfile
diff --git a/runtime/Dockerfile b/runtime/Dockerfile
new file mode 100644
index 0000000000000000000000000000000000000000..89b9175b5260ec3e0acc9dc10c99d117162c6aa7
--- /dev/null
+++ b/runtime/Dockerfile
@@ -0,0 +1,13 @@
+FROM google/dart
+
+WORKDIR /app
+ONBUILD ADD pubspec.yaml /app/
+ONBUILD ADD pubspec.lock /app/
+ONBUILD ENV PUB_CACHE /var/cache/pub
proppy 2014/07/02 20:55:55 can we move that to the google/dart image?
Søren Gjesse 2014/07/03 10:36:41 Yes - but maybe we don't need it after all.
+ONBUILD RUN /usr/lib/dart/bin/pub get
+ONBUILD ADD . /app
+ONBUILD RUN /usr/lib/dart/bin/pub get
proppy 2014/07/02 20:55:55 maybe we can get rid of that if we suggest adding
kustermann 2014/07/03 09:40:05 I think Soeren did this in order to cause less doc
Søren Gjesse 2014/07/03 10:36:41 Yes the first invocation of 'RUN /usr/lib/dart/bin
Søren Gjesse 2014/07/03 10:36:41 Yes.
+
+CMD []
+ENTRYPOINT ["/usr/bin/dart", "/app/bin/server.dart"]
+EXPOSE 8080

Powered by Google App Engine
This is Rietveld 408576698