runtime/Dockerfile - Issue 367903008: Create a set of Dart dockerfiles

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/Dockerfile

Issue 367903008: Create a set of Dart dockerfiles (Closed) Base URL: https://github.com/dart-lang/dart_docker.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 FROM google/dart

	2

	3 WORKDIR /app

	4 ONBUILD ADD pubspec.yaml /app/

	5 ONBUILD ADD pubspec.lock /app/

	6 ONBUILD ENV PUB_CACHE /var/cache/pub
	proppy 2014/07/02 20:55:55 can we move that to the google/dart image? can we move that to the google/dart image? Søren Gjesse 2014/07/03 10:36:41 Yes - but maybe we don't need it after all. Show quoted text On 2014/07/02 20:55:55, proppy wrote: > can we move that to the google/dart image? Yes - but maybe we don't need it after all.
	7 ONBUILD RUN /usr/lib/dart/bin/pub get

	8 ONBUILD ADD . /app

	9 ONBUILD RUN /usr/lib/dart/bin/pub get
	proppy 2014/07/02 20:55:55 maybe we can get rid of that if we suggest adding maybe we can get rid of that if we suggest adding a .dockerignore file with packages in the application directory. kustermann 2014/07/03 09:40:05 I think Soeren did this in order to cause less doc Show quoted text On 2014/07/02 20:55:55, proppy wrote: > maybe we can get rid of that if we suggest adding a .dockerignore file with > packages in the application directory. I think Soeren did this in order to cause less docker images, since only the "ADD . /app" will usually create a different image ID (the previous steps should always result in the same image ID). i.e. it might be a space saving technique. Søren Gjesse 2014/07/03 10:36:41 Yes the first invocation of 'RUN /usr/lib/dart/bin Show quoted text On 2014/07/03 09:40:05, kustermann wrote: > On 2014/07/02 20:55:55, proppy wrote: > > maybe we can get rid of that if we suggest adding a .dockerignore file with > > packages in the application directory. > > I think Soeren did this in order to cause less docker images, since only the > "ADD . /app" will usually create a different image ID (the previous steps should > always result in the same image ID). i.e. it might be a space saving technique. Yes the first invocation of 'RUN /usr/lib/dart/bin/pub get' creates a layer where the pub cache is populated with the packages currently used. This is assuming that this will not change that often. However when adding the rest of the application the package dir will be wrong. Running 'RUN /usr/lib/dart/bin/pub get' again or adding packages to .dockerignore fixes this. I find that requiring .dockerignore will lead to issues, however if you have it the secone invocation of 'RUN /usr/lib/dart/bin/pub get' should be a no-op. Søren Gjesse 2014/07/03 10:36:41 Yes. Show quoted text On 2014/07/02 20:55:55, proppy wrote: > maybe we can get rid of that if we suggest adding a .dockerignore file with > packages in the application directory. Yes.
	10

	11 CMD []

	12 ENTRYPOINT ["/usr/bin/dart", "/app/bin/server.dart"]

	13 EXPOSE 8080

OLD	NEW

« hello/bin/server.dart ('K') | « hello/web/index.html ('k') | runtime/README.md » ('j') | runtime/README.md » ('J')