Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1365)

Unified Diff: Source/web/tests/ActivityLoggerTest.cpp

Issue 367483005: Refactoring activity logger (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLFormElement.idl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/tests/ActivityLoggerTest.cpp
diff --git a/Source/web/tests/ActivityLoggerTest.cpp b/Source/web/tests/ActivityLoggerTest.cpp
index a9e52f42b71258cd92cabed17a41641e4d64d25c..2e7b0a962833ed5779e174a9a75ca53895466a8e 100644
--- a/Source/web/tests/ActivityLoggerTest.cpp
+++ b/Source/web/tests/ActivityLoggerTest.cpp
@@ -95,7 +95,7 @@ protected:
bool verifyActivities(const String& activities)
{
Vector<String> activityVector;
- activities.split('\n', activityVector);
+ activities.split("\n", activityVector);
return m_activityLogger->verifyActivities(activityVector);
}
@@ -433,4 +433,30 @@ TEST_F(ActivityLoggerTest, DISABLED_FormActionAttribute)
ASSERT_TRUE(verifyActivities(expectedActivities));
}
+TEST_F(ActivityLoggerTest, DISABLED_LocalDOMWindowAttribute)
+{
+ const char* code =
+ "location.href = 'data:text/html;charset=utf-8,A';"
+ "location.assign('data:text/html;charset=utf-8,B');"
+ "location.replace('data:text/html;charset=utf-8,C');"
+ "location.protocol = 'protocol';"
+ "location.pathname = 'pathname';"
+ "location.search = 'search';"
+ "location.hash = 'hash';"
+ "location.href = 'about:blank';";
+ const char* expectedActivities =
+ "blinkSetAttribute | LocalDOMWindow | url | about:blank | data:text/html;charset=utf-8,A\n"
+ "blinkSetAttribute | LocalDOMWindow | url | about:blank | data:text/html;charset=utf-8,B\n"
+ "blinkSetAttribute | LocalDOMWindow | url | about:blank | data:text/html;charset=utf-8,C\n"
+ "blinkSetAttribute | LocalDOMWindow | url | about:blank | protocol:blank\n"
+ "blinkSetAttribute | LocalDOMWindow | url | about:blank | about:pathname\n"
+ "blinkSetAttribute | LocalDOMWindow | url | about:blank | about:blank?search\n"
+ "blinkSetAttribute | LocalDOMWindow | url | about:blank | about:blank#hash\n"
+ "blinkSetAttribute | LocalDOMWindow | url | about:blank#hash | about:blank\n";
+ executeScriptInMainWorld(code);
+ ASSERT_TRUE(verifyActivities(""));
+ executeScriptInIsolatedWorld(code);
+ ASSERT_TRUE(verifyActivities(expectedActivities));
+}
+
} // namespace
« no previous file with comments | « Source/core/html/HTMLFormElement.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698