Refactoring activity logger

Source/web/tests/ActivityLoggerTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 
 #include "FrameTestHelpers.h"
 #include "bindings/core/v8/ScriptController.h"
 #include "bindings/core/v8/V8DOMActivityLogger.h"
 #include "web/WebLocalFrameImpl.h"
@@ skipping 77 matching lines @@
         Vector<ScriptSourceCode> sources;
         sources.append(ScriptSourceCode(script));
         Vector<v8::Local<v8::Value> > results;
         m_scriptController->executeScriptInIsolatedWorld(isolatedWorldId, sources, extensionGroup, 0);
         runPendingTasks();
     }
 
     bool verifyActivities(const String& activities)
     {
         Vector<String> activityVector;
-        activities.split('\n', activityVector);
+        activities.split("\n", activityVector);
         return m_activityLogger->verifyActivities(activityVector);
     }
 
 private:
     static const int isolatedWorldId = 1;
     static const int extensionGroup = 0;
 
     WebViewHelper m_webViewHelper;
     ScriptController* m_scriptController;
     // TestActivityLogger is owned by a static table within V8DOMActivityLogger
@@ skipping 317 matching lines @@
         "blinkSetAttribute | form | action | data:text/html;charset=utf-8,A | data:text/html;charset=utf-8,B\n"
         "blinkSetAttribute | form | action | data:text/html;charset=utf-8,B | data:text/html;charset=utf-8,C\n"
         "blinkSetAttribute | form | action | data:text/html;charset=utf-8,C | data:text/html;charset=utf-8,D\n"
         "blinkSetAttribute | form | action | data:text/html;charset=utf-8,D | data:text/html;charset=utf-8,E";
     executeScriptInMainWorld(code);
     ASSERT_TRUE(verifyActivities(""));
     executeScriptInIsolatedWorld(code);
     ASSERT_TRUE(verifyActivities(expectedActivities));
 }
 
+TEST_F(ActivityLoggerTest, DISABLED_LocalDOMWindowAttribute)
+{
+    const char* code =
+        "location.href = 'data:text/html;charset=utf-8,A';"
+        "location.assign('data:text/html;charset=utf-8,B');"
+        "location.replace('data:text/html;charset=utf-8,C');"
+        "location.protocol = 'protocol';"
+        "location.pathname = 'pathname';"
+        "location.search = 'search';"
+        "location.hash = 'hash';"
+        "location.href = 'about:blank';";
+    const char* expectedActivities =
+        "blinkSetAttribute | LocalDOMWindow | url | about:blank | data:text/html;charset=utf-8,A\n"
+        "blinkSetAttribute | LocalDOMWindow | url | about:blank | data:text/html;charset=utf-8,B\n"
+        "blinkSetAttribute | LocalDOMWindow | url | about:blank | data:text/html;charset=utf-8,C\n"
+        "blinkSetAttribute | LocalDOMWindow | url | about:blank | protocol:blank\n"
+        "blinkSetAttribute | LocalDOMWindow | url | about:blank | about:pathname\n"
+        "blinkSetAttribute | LocalDOMWindow | url | about:blank | about:blank?search\n"
+        "blinkSetAttribute | LocalDOMWindow | url | about:blank | about:blank#hash\n"
+        "blinkSetAttribute | LocalDOMWindow | url | about:blank#hash | about:blank\n";
+    executeScriptInMainWorld(code);
+    ASSERT_TRUE(verifyActivities(""));
+    executeScriptInIsolatedWorld(code);
+    ASSERT_TRUE(verifyActivities(expectedActivities));
+}
+
 } // namespace