Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 367373007: Parser cleanup: Cached data cannot contain errors. (Closed)

Created:
6 years, 5 months ago by marja
Modified:
6 years, 5 months ago
Reviewers:
rossberg
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Parser cleanup: Cached data cannot contain errors (removed dead code) We no longer store the errors in cached data (see Parser::ParseProgram()) and storing them is an unnecessary optimization. In addition, the code which extracts errors from cached data is wrong, since it stores the result of BuildArgs (in ReportMessageAt) and then deletes it. R=rossberg@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=22229

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M src/parser.cc View 1 chunk +1 line, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
marja
rossberg, ptal
6 years, 5 months ago (2014-07-04 12:42:23 UTC) #1
rossberg
lgtm
6 years, 5 months ago (2014-07-07 09:03:58 UTC) #2
marja
6 years, 5 months ago (2014-07-07 09:32:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22229 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698