Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Unified Diff: src/parser.cc

Issue 367373007: Parser cleanup: Cached data cannot contain errors. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parser.cc
diff --git a/src/parser.cc b/src/parser.cc
index 7566bc3e34851a992d5cad8dda4b8e22cfd01557..261de4eed78e2021a3c8ff4dfa21dd7513bcb977 100644
--- a/src/parser.cc
+++ b/src/parser.cc
@@ -4857,20 +4857,7 @@ bool Parser::Parse() {
}
} else {
SetCachedData(info()->cached_data(), info()->cached_data_mode());
- if (info()->cached_data_mode() == CONSUME_CACHED_DATA &&
- (*info()->cached_data())->has_error()) {
- ScriptData* cached_data = *(info()->cached_data());
- Scanner::Location loc = cached_data->MessageLocation();
- const char* message = cached_data->BuildMessage();
- const char* arg = cached_data->BuildArg();
- ParserTraits::ReportMessageAt(loc, message, arg,
- cached_data->IsReferenceError());
- DeleteArray(message);
- DeleteArray(arg);
- ASSERT(info()->isolate()->has_pending_exception());
- } else {
- result = ParseProgram();
- }
+ result = ParseProgram();
}
info()->SetFunction(result);
ASSERT(ast_value_factory_->IsInternalized());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698