Source/modules/quota/DeprecatedStorageQuota.h - Issue 367113005: Remove destructors from ScriptWrappable objects in modules/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/quota/DeprecatedStorageQuota.h

Issue 367113005: Remove destructors from ScriptWrappable objects in modules/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add Finalizable transition type Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/push_messaging/PushManager.h ('K') | « Source/modules/quota/DeprecatedStorageInfo.cpp ('k') | Source/modules/quota/DeprecatedStorageQuota.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/quota/DeprecatedStorageQuota.h

diff --git a/Source/modules/quota/DeprecatedStorageQuota.h b/Source/modules/quota/DeprecatedStorageQuota.h

index a5cd6751514bc5f60c2e3b7895d0ce43b8c0e517..b29a7e9b17e177bbdf905332fc496ed9e86fe58d 100644

--- a/Source/modules/quota/DeprecatedStorageQuota.h

+++ b/Source/modules/quota/DeprecatedStorageQuota.h

@@ -42,7 +42,8 @@ class StorageErrorCallback;

class StorageQuotaCallback;

class StorageUsageCallback;

-class DeprecatedStorageQuota FINAL : public GarbageCollectedFinalized<DeprecatedStorageQuota>, public ScriptWrappable {

+class DeprecatedStorageQuota FINAL : public GarbageCollectedFinalizedWillBeGarbageCollected<DeprecatedStorageQuota>, public ScriptWrappable {

+ DECLARE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(DeprecatedStorageQuota);

public:

enum Type {

Temporary,

@@ -58,8 +59,6 @@ public:

void requestQuota(ExecutionContext*, unsigned long long newQuotaInBytes, PassOwnPtr<StorageQuotaCallback>, PassOwnPtr<StorageErrorCallback>);

- ~DeprecatedStorageQuota();

void trace(Visitor*) { }

private: