Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1744)

Unified Diff: Source/modules/push_messaging/PushManager.h

Issue 367113005: Remove destructors from ScriptWrappable objects in modules/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add Finalizable transition type Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/performance/WorkerPerformance.cpp ('k') | Source/modules/push_messaging/PushManager.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/push_messaging/PushManager.h
diff --git a/Source/modules/push_messaging/PushManager.h b/Source/modules/push_messaging/PushManager.h
index 54854033e1abfda4acc3367b22dc3f64f70911a9..3df33c39990344013dab9fc067ea7ef1bd42467a 100644
--- a/Source/modules/push_messaging/PushManager.h
+++ b/Source/modules/push_messaging/PushManager.h
@@ -15,13 +15,13 @@ class ExecutionContext;
class ScriptPromise;
class ScriptState;
-class PushManager FINAL : public GarbageCollectedFinalized<PushManager>, public ScriptWrappable {
+class PushManager FINAL : public GarbageCollectedFinalizedWillBeGarbageCollected<PushManager>, public ScriptWrappable {
+ DECLARE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(PushManager);
haraken 2014/07/04 01:25:29 Since PushManager is FINAL, it looks OK to not use
public:
static PushManager* create()
{
return new PushManager();
}
- virtual ~PushManager();
ScriptPromise registerPushMessaging(ScriptState*, const String& senderId);
« no previous file with comments | « Source/modules/performance/WorkerPerformance.cpp ('k') | Source/modules/push_messaging/PushManager.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698