Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: Source/modules/push_messaging/PushManager.h

Issue 367113005: Remove destructors from ScriptWrappable objects in modules/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add Finalizable transition type Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef PushManager_h 5 #ifndef PushManager_h
6 #define PushManager_h 6 #define PushManager_h
7 7
8 #include "bindings/core/v8/ScriptWrappable.h" 8 #include "bindings/core/v8/ScriptWrappable.h"
9 #include "platform/heap/Handle.h" 9 #include "platform/heap/Handle.h"
10 #include "wtf/text/WTFString.h" 10 #include "wtf/text/WTFString.h"
11 11
12 namespace WebCore { 12 namespace WebCore {
13 13
14 class ExecutionContext; 14 class ExecutionContext;
15 class ScriptPromise; 15 class ScriptPromise;
16 class ScriptState; 16 class ScriptState;
17 17
18 class PushManager FINAL : public GarbageCollectedFinalized<PushManager>, public ScriptWrappable { 18 class PushManager FINAL : public GarbageCollectedFinalizedWillBeGarbageCollected <PushManager>, public ScriptWrappable {
19 DECLARE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(PushManager);
haraken 2014/07/04 01:25:29 Since PushManager is FINAL, it looks OK to not use
19 public: 20 public:
20 static PushManager* create() 21 static PushManager* create()
21 { 22 {
22 return new PushManager(); 23 return new PushManager();
23 } 24 }
24 virtual ~PushManager();
25 25
26 ScriptPromise registerPushMessaging(ScriptState*, const String& senderId); 26 ScriptPromise registerPushMessaging(ScriptState*, const String& senderId);
27 27
28 void trace(Visitor*) { } 28 void trace(Visitor*) { }
29 29
30 private: 30 private:
31 PushManager(); 31 PushManager();
32 }; 32 };
33 33
34 } // namespace WebCore 34 } // namespace WebCore
35 35
36 #endif // PushManager_h 36 #endif // PushManager_h
OLDNEW
« no previous file with comments | « Source/modules/performance/WorkerPerformance.cpp ('k') | Source/modules/push_messaging/PushManager.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698