Source/modules/gamepad/GamepadButton.h - Issue 367113005: Remove destructors from ScriptWrappable objects in modules/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/gamepad/GamepadButton.h

Issue 367113005: Remove destructors from ScriptWrappable objects in modules/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add Finalizable transition type Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/device_orientation/DeviceRotationRate.h ('k') | Source/modules/gamepad/GamepadButton.cpp » ('j') | Source/modules/push_messaging/PushManager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/gamepad/GamepadButton.h

diff --git a/Source/modules/gamepad/GamepadButton.h b/Source/modules/gamepad/GamepadButton.h

index 878aaca5470f0e4b1eb9f90c41eedc5796c2252b..1cfc5b768a72d8ffbbc2ce3f7c968de84f1163a5 100644

--- a/Source/modules/gamepad/GamepadButton.h

+++ b/Source/modules/gamepad/GamepadButton.h

@@ -11,10 +11,10 @@

namespace WebCore {

-class GamepadButton FINAL : public GarbageCollectedFinalized<GamepadButton>, public ScriptWrappable {

+class GamepadButton FINAL : public GarbageCollectedFinalizedWillBeGarbageCollected<GamepadButton>, public ScriptWrappable {

+ DECLARE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(GamepadButton);

public:

static GamepadButton* create();

- ~GamepadButton();

double value() const { return m_value; }

void setValue(double val) { m_value = val; }