Move GLIB_DISABLE_DEPRECATION_WARNINGS define to a more general place.

Move GLIB_DISABLE_DEPRECATION_WARNINGS define to a more general place.

The GLIB_DISABLE_DEPRECATION_WARNINGS define disables the deprecation
warnings which is caused by the usage of the g_settings_list_schemas
method. Moving the define to the build scripts avoids any future build
errors (-Werror) and warning reports.

BUG=391250
TEST=ninja -C out/Release chrome

Committed: https://crrev.com/3a31d8e495b1d04a01f9e6c57fac608fee0285e3
Cr-Commit-Position: refs/heads/master@{#292608}

[vabr (Chromium), 2014-07-03 13:15:52]

Sorry, I don't feel qualified for this review.
I'm Cc-ing mgiuca@ because of the mention of him in the TODO.
I'm also Cc-ing brettw@ as the sole OWNER of build/config.
You will also need to choose a net/ OWNER to review the net/proxy part (see
https://code.google.com/p/chromium/codesearch#chromium/src/net/OWNERS&sq=pack...
for a list).
Cheers,
Vaclav

[elecro, 2014-07-03 14:18:20]

On 2014/07/03 13:15:52, vabr (Chromium) wrote:
> Sorry, I don't feel qualified for this review.
> I'm Cc-ing mgiuca@ because of the mention of him in the TODO.
> I'm also Cc-ing brettw@ as the sole OWNER of build/config.
> You will also need to choose a net/ OWNER to review the net/proxy part (see
>
https://code.google.com/p/chromium/codesearch#chromium/src/net/OWNERS&sq=pack...
> for a list).
> Cheers,
> Vaclav

Ah... sorry I've messed up the reviewer selection. Will fix it in a sec.

[elecro, 2014-07-03 14:24:39]

Update reviewers:
+ brettw@ for build/config
+ eroman@ for net/ (and because he reviewed the relevant CL:
https://codereview.chromium.org/264963005)

[Matt Giuca, 2014-07-04 00:26:52]

I'm not sure what this change accomplishes. The original CL
(http://src.chromium.org/viewvc/chrome?revision=268417&view=revision) was
specifically targeted at the proxy_config_service_linux.cc file, which is the
only file that uses g_settings_list_schemas. Since we generally want to see
deprecation warnings, I think it's useful to not have them suppressed for all
files that include libgio. You could inadvertently suppress other useful
warnings.

I see the point of the CL, which is that if we started using
g_settings_list_schemas in another file, we would need to suppress it there too,
but I don't think this justifies globally suppressing warnings (I think we
should deal with it when and if we need to use it in another file).

Also, because of the dual build systems, this means duplicating the logic and
the comment, which I'd rather keep in just one place. So I'd prefer not to make
this change.

[elecro, 2014-07-08 07:13:45]

On 2014/07/04 00:26:52, Matt Giuca wrote:
> I'm not sure what this change accomplishes. The original CL
> (http://src.chromium.org/viewvc/chrome?revision=268417&view=revision) was
> specifically targeted at the proxy_config_service_linux.cc file, which is the
> only file that uses g_settings_list_schemas. Since we generally want to see
> deprecation warnings, I think it's useful to not have them suppressed for all
> files that include libgio. You could inadvertently suppress other useful
> warnings.

The reason for this change was to suppress the warning during the
libgio_loader.cc build (the warning can be seen in the related bugreport) which
is a generated file and also uses the g_settings_list_schemas method. 

I know this isn't really an ideal change, but the other options (IMHO) would be
to change the generator for libgio_loader.cc or just don't care about the
reported warning.

[DaleCurtis, 2014-07-17 20:35:43]

Any update on this?  The GN build on Goobuntu Trusty is affected on during
construction of the libgio loader.  This patch fixes that issue.  Without the
net/ changes a redefinition error will be issued.

lgtm, but I defer to the OWNERS on this thread.

[elecro, 2014-07-22 13:05:48]

On 2014/07/17 20:35:43, DaleCurtis wrote:
> Any update on this?  The GN build on Goobuntu Trusty is affected on during
> construction of the libgio loader.  This patch fixes that issue.  Without the
> net/ changes a redefinition error will be issued.
> 
> lgtm, but I defer to the OWNERS on this thread.

ping?

[brettw, 2014-07-22 17:13:11]

lgtm

[Paweł Hajdan Jr., 2014-07-23 10:43:39]

https://codereview.chromium.org/367113004/diff/1/build/linux/system.gyp
File build/linux/system.gyp (right):

https://codereview.chromium.org/367113004/diff/1/build/linux/system.gyp#newco...
build/linux/system.gyp:543: # glib >=2.40 deprecate g_settings_list_schemas in
favor of
nit: Shouldn't this block be de-indented 2 spaces?

Also, please wrap on 80 cols.

[elecro, 2014-07-23 13:13:51]

https://codereview.chromium.org/367113004/diff/1/build/linux/system.gyp
File build/linux/system.gyp (right):

https://codereview.chromium.org/367113004/diff/1/build/linux/system.gyp#newco...
build/linux/system.gyp:543: # glib >=2.40 deprecate g_settings_list_schemas in
favor of
On 2014/07/23 10:43:39, Paweł Hajdan Jr. wrote:
> nit: Shouldn't this block be de-indented 2 spaces?
> 
> Also, please wrap on 80 cols.

Yeah, thanks missed that.
CL rebased, and now wraps on 80 cols.

[Paweł Hajdan Jr., 2014-07-24 15:19:36]

LGTM

[elecro, 2014-08-27 16:58:23]

pgal.u-szeged@partner.samsung.com changed reviewers:
+ rvargas@chromium.org

[elecro, 2014-08-27 16:58:23]

+ rvargas@ for net/ change

[rvargas (doing something else), 2014-08-27 18:12:07]

lgtm

[elecro, 2014-08-29 09:34:20]

The CQ bit was checked by pgal.u-szeged@partner.samsung.com

[commit-bot: I haz the power, 2014-08-29 09:35:13]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/pgal.u-szeged@partner.samsung.com/3671...

[commit-bot: I haz the power, 2014-08-29 10:54:15]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-29 12:05:55]

Committed patchset #3 (id:40001) as 9674379addd95f13a0ad2729dcfdbe4aacb4c35e

[commit-bot: I haz the power, 2014-09-10 03:07:45]

Patchset 3 (id:??) landed as
https://crrev.com/3a31d8e495b1d04a01f9e6c57fac608fee0285e3
Cr-Commit-Position: refs/heads/master@{#292608}