Fixed Linux build with glib 2.40 (Ubuntu 14.04).

Fixed Linux build with glib 2.40 (Ubuntu 14.04).

In proxy_config_service_linux, disabled glib deprecation warnings. The
function g_settings_list_schemas got deprecated in 2.40, but its
replacement is not available in older glib versions (such as the one the
build bots currently use, 2.32), so for now, disable the warnings.

BUG=351911
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268417

[Matt Giuca, 2014-05-02 00:24:45]

This is an alternative to https://codereview.chromium.org/256803006/. I don't
think it's appropriate to conditionally use the new function, or it will mean
any Chrome binary built against glib 2.40 will be incompatible with older
versions. Better to disable the warning for now, and continue using the old
function (until it is actually removed).

Tested on both Ubuntu 12.04 and 14.04.

[eroman, 2014-05-02 00:58:15]

lgtm

[Matt Giuca, 2014-05-02 22:57:55]

phajdan.jr: Ping, did you have any thoughts? (I don't need OWNERS approval from
you, just put you as reviewer since you reviewed the other CL.) I'd like to get
this in ASAP so developers who upgraded to 14.04 can work.

[Matt Giuca, 2014-05-04 23:39:04]

Turns out this issue was already fixed for Clang builds:
https://codereview.chromium.org/267623002

But I think that was the wrong fix because this is not just a Clang issue (it's
deprecated for all compilers). I'll keep this CL open and try out the build on
GCC later and see if it's still failing to compile. If it affects GCC as well,
I'll probably want to replace that fix with this (more general) one.

[Paweł Hajdan Jr., 2014-05-05 11:25:09]

LGTM with a comment, thanks!

https://codereview.chromium.org/264963005/diff/20001/net/proxy/proxy_config_s...
File net/proxy/proxy_config_service_linux.cc (right):

https://codereview.chromium.org/264963005/diff/20001/net/proxy/proxy_config_s...
net/proxy/proxy_config_service_linux.cc:11: #define
GLIB_DISABLE_DEPRECATION_WARNINGS
Please add a TODO to remove this when we drop support for Ubuntu Precise.

[Matt Giuca, 2014-05-05 12:20:26]

Thanks. I just tested on GCC and it is indeed still an issue. I'll commit this
tomorrow.

https://codereview.chromium.org/264963005/diff/20001/net/proxy/proxy_config_s...
File net/proxy/proxy_config_service_linux.cc (right):

https://codereview.chromium.org/264963005/diff/20001/net/proxy/proxy_config_s...
net/proxy/proxy_config_service_linux.cc:11: #define
GLIB_DISABLE_DEPRECATION_WARNINGS
I'm not at my desk at the moment, but I will do this in the morning (Sydney
time) and commit this.

[Matt Giuca, 2014-05-05 23:45:23]

https://codereview.chromium.org/264963005/diff/20001/net/proxy/proxy_config_s...
File net/proxy/proxy_config_service_linux.cc (right):

https://codereview.chromium.org/264963005/diff/20001/net/proxy/proxy_config_s...
net/proxy/proxy_config_service_linux.cc:11: #define
GLIB_DISABLE_DEPRECATION_WARNINGS
On 2014/05/05 12:20:26, Matt Giuca wrote:
> I'm not at my desk at the moment, but I will do this in the morning (Sydney
> time) and commit this.

Done. (Note that my comment says Ubuntu 13.10 / saucy and earlier, not 12.04 /
precise, because saucy is the last version of Ubuntu that does not support
g_settings_schema_source_list_schemas.)

[Matt Giuca, 2014-05-05 23:45:28]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-05-05 23:46:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mgiuca@chromium.org/264963005/40001

[commit-bot: I haz the power, 2014-05-06 04:17:55]

Change committed as 268417