Issue 367093003: DevTools: More code reduce via using document.createElementWithClass and document.createChild.

Issue 367093003: DevTools: More code reduce via using document.createElementWithClass and document.createChild. (Closed)

Created:
6 years, 5 months ago by aandrey

Modified:
6 years, 5 months ago

Reviewers:
apavlov, vsevik, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: More code reduce via using document.createElementWithClass and document.createChild. R=vsevik, apavlov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177419

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -125 lines)			Patch
M	Source/devtools/front_end/common/DOMExtension.js	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/components/FlameChart.js	View	1 chunk	+3 lines, -7 lines	0 comments	Download
M	Source/devtools/front_end/console/ConsoleView.js	View	5 chunks	+4 lines, -11 lines	0 comments	Download
M	Source/devtools/front_end/elements/Spectrum.js	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	Source/devtools/front_end/source_frame/GoToLineDialog.js	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	Source/devtools/front_end/sources/TargetsToolbar.js	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineView.js	View	5 chunks	+9 lines, -17 lines	0 comments	Download
M	Source/devtools/front_end/ui/ProgressIndicator.js	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/devtools/front_end/ui/SettingsUI.js	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	Source/devtools/front_end/ui/SidebarTreeElement.js	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	Source/devtools/front_end/ui/SoftContextMenu.js	View	5 chunks	+13 lines, -24 lines	0 comments	Download
M	Source/devtools/front_end/ui/StatusBarButton.js	View	3 chunks	+6 lines, -16 lines	0 comments	Download
M	Source/devtools/front_end/ui/SuggestBox.js	View	3 chunks	+6 lines, -12 lines	0 comments	Download
M	Source/devtools/front_end/ui/TabbedPane.js	View	3 chunks	+4 lines, -7 lines	0 comments	Download
M	Source/devtools/front_end/ui/TextPrompt.js	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/367093003/1

6 years, 5 months ago (2014-07-02 18:32:40 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...

6 years, 5 months ago (2014-07-02 19:39:40 UTC) #5

Message was sent while issue was closed.

Change committed as 177419

Expand Messages | Collapse Messages