Source/devtools/front_end/components/FlameChart.js - Issue 367093003: DevTools: More code reduce via using document.createElementWithClass and document.createChild.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/components/FlameChart.js

Issue 367093003: DevTools: More code reduce via using document.createElementWithClass and document.createChild. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/devtools/front_end/components/FlameChart.js

diff --git a/Source/devtools/front_end/components/FlameChart.js b/Source/devtools/front_end/components/FlameChart.js

index 9f4bd0e328ef37b525e02d5ad0e79ff804bb1447..4f338aaaeccac32bbbbf0f74b88daa6b9b628e1b 100644

--- a/Source/devtools/front_end/components/FlameChart.js

+++ b/Source/devtools/front_end/components/FlameChart.js

@@ -829,15 +829,11 @@ WebInspector.FlameChart.prototype = {

_buildEntryInfo: function(entryInfo)

{

- var infoTable = document.createElement("table");

- infoTable.className = "info-table";

+ var infoTable = document.createElementWithClass("table", "info-table");

for (var i = 0; i < entryInfo.length; ++i) {

var row = infoTable.createChild("tr");

- var titleCell = row.createChild("td");

- titleCell.textContent = entryInfo[i].title;

- titleCell.className = "title";

- var textCell = row.createChild("td");

- textCell.textContent = entryInfo[i].text;

+ row.createChild("td", "title").textContent = entryInfo[i].title;

+ row.createChild("td").textContent = entryInfo[i].text;

}

return infoTable;

« no previous file with comments | « Source/devtools/front_end/common/DOMExtension.js ('k') | Source/devtools/front_end/console/ConsoleView.js » ('j') | no next file with comments »