Issue 367053002: MIPS: KeyedLoadIC should have same register spec as LoadIC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 367053002: MIPS: KeyedLoadIC should have same register spec as LoadIC. (Closed)

Created:
6 years, 5 months ago by kilvadyb

Modified:
6 years, 5 months ago

Reviewers:
Paul Lind, danno, kisg, mvstanton, palfia, dusmil

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: KeyedLoadIC should have same register spec as LoadIC. Port r22103 (2c36867) Original commit message: On arm, arm64 and x64 there is a different register specification between LoadIC and KeyedLoadIC. It would be nicer if these are the same, allowing some key optimizations. BUG= R=palfia@homejinni.com Committed: https://code.google.com/p/v8/source/detail?r=22168

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+131 lines, -181 lines)			Patch
M	src/mips/code-stubs-mips.cc	View	1 chunk	+7 lines, -17 lines	0 comments	Download
M	src/mips/debug-mips.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View	13 chunks	+36 lines, -45 lines	0 comments	Download
M	src/mips/ic-mips.cc	View	16 chunks	+70 lines, -84 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/mips/stub-cache-mips.cc	View	2 chunks	+13 lines, -28 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r22168.

Expand Messages | Collapse Messages