Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 366953002: DevTools: Put EventDispatch type into the data object. (Closed)

Created:
6 years, 5 months ago by alph
Modified:
6 years, 5 months ago
Reviewers:
caseq, yurys, pfeldman, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Put EventDispatch type into the data object. That's where the front-end expects it to reside. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177466

Patch Set 1 #

Total comments: 2

Patch Set 2 : Made event passed by ref. #

Patch Set 3 : Updated EventDispatch in LocalDOMWindow.cpp + Updated the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M LayoutTests/inspector-protocol/timeline/timeline-dispatchEvent.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/EventDispatcher.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorTraceEvents.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorTraceEvents.cpp View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
alph
6 years, 5 months ago (2014-07-02 09:05:54 UTC) #1
caseq
lgtm https://codereview.chromium.org/366953002/diff/1/Source/core/inspector/InspectorTraceEvents.cpp File Source/core/inspector/InspectorTraceEvents.cpp (right): https://codereview.chromium.org/366953002/diff/1/Source/core/inspector/InspectorTraceEvents.cpp#newcode342 Source/core/inspector/InspectorTraceEvents.cpp:342: PassRefPtr<TraceEvent::ConvertableToTraceFormat> InspectorEventDispatchEvent::data(const Event* event) We do not expect ...
6 years, 5 months ago (2014-07-02 09:20:28 UTC) #2
alph
Pavel, could you please do the owners review. Thanks. https://codereview.chromium.org/366953002/diff/1/Source/core/inspector/InspectorTraceEvents.cpp File Source/core/inspector/InspectorTraceEvents.cpp (right): https://codereview.chromium.org/366953002/diff/1/Source/core/inspector/InspectorTraceEvents.cpp#newcode342 Source/core/inspector/InspectorTraceEvents.cpp:342: ...
6 years, 5 months ago (2014-07-02 09:57:06 UTC) #3
pfeldman
lgtm
6 years, 5 months ago (2014-07-03 07:02:43 UTC) #4
loislo
The CQ bit was checked by loislo@chromium.org
6 years, 5 months ago (2014-07-03 07:03:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/366953002/10004
6 years, 5 months ago (2014-07-03 07:03:45 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-03 08:40:22 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-03 09:05:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/14607)
6 years, 5 months ago (2014-07-03 09:05:53 UTC) #9
alph
The CQ bit was checked by alph@chromium.org
6 years, 5 months ago (2014-07-03 10:26:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/366953002/30001
6 years, 5 months ago (2014-07-03 10:26:44 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-03 11:33:00 UTC) #12
Message was sent while issue was closed. 
Change committed as 177466

Powered by Google App Engine
This is Rietveld 408576698