Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Side by Side Diff: Source/core/frame/LocalDOMWindow.cpp

Issue 366953002: DevTools: Put EventDispatch type into the data object. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updated EventDispatch in LocalDOMWindow.cpp + Updated the test Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/events/EventDispatcher.cpp ('k') | Source/core/inspector/InspectorTraceEvents.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 1610 matching lines...) Expand 10 before | Expand all | Expand 10 after
1621 { 1621 {
1622 ASSERT(!NoEventDispatchAssertion::isEventDispatchForbidden()); 1622 ASSERT(!NoEventDispatchAssertion::isEventDispatchForbidden());
1623 1623
1624 RefPtrWillBeRawPtr<EventTarget> protect(this); 1624 RefPtrWillBeRawPtr<EventTarget> protect(this);
1625 RefPtrWillBeRawPtr<Event> event = prpEvent; 1625 RefPtrWillBeRawPtr<Event> event = prpEvent;
1626 1626
1627 event->setTarget(prpTarget ? prpTarget : this); 1627 event->setTarget(prpTarget ? prpTarget : this);
1628 event->setCurrentTarget(this); 1628 event->setCurrentTarget(this);
1629 event->setEventPhase(Event::AT_TARGET); 1629 event->setEventPhase(Event::AT_TARGET);
1630 1630
1631 TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "EventDispatch" , "type", event->type().ascii()); 1631 TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "EventDispatch" , "data", InspectorEventDispatchEvent::data(*event));
1632 // FIXME(361045): remove InspectorInstrumentation calls once DevTools Timeli ne migrates to tracing. 1632 // FIXME(361045): remove InspectorInstrumentation calls once DevTools Timeli ne migrates to tracing.
1633 InspectorInstrumentationCookie cookie = InspectorInstrumentation::willDispat chEventOnWindow(frame(), *event, this); 1633 InspectorInstrumentationCookie cookie = InspectorInstrumentation::willDispat chEventOnWindow(frame(), *event, this);
1634 1634
1635 bool result = fireEventListeners(event.get()); 1635 bool result = fireEventListeners(event.get());
1636 1636
1637 InspectorInstrumentation::didDispatchEventOnWindow(cookie); 1637 InspectorInstrumentation::didDispatchEventOnWindow(cookie);
1638 1638
1639 return result; 1639 return result;
1640 } 1640 }
1641 1641
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
1941 visitor->trace(m_localStorage); 1941 visitor->trace(m_localStorage);
1942 visitor->trace(m_applicationCache); 1942 visitor->trace(m_applicationCache);
1943 visitor->trace(m_performance); 1943 visitor->trace(m_performance);
1944 visitor->trace(m_css); 1944 visitor->trace(m_css);
1945 visitor->trace(m_eventQueue); 1945 visitor->trace(m_eventQueue);
1946 WillBeHeapSupplementable<LocalDOMWindow>::trace(visitor); 1946 WillBeHeapSupplementable<LocalDOMWindow>::trace(visitor);
1947 EventTargetWithInlineData::trace(visitor); 1947 EventTargetWithInlineData::trace(visitor);
1948 } 1948 }
1949 1949
1950 } // namespace WebCore 1950 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/events/EventDispatcher.cpp ('k') | Source/core/inspector/InspectorTraceEvents.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698