LayoutTests/screen_orientation/page-visibility.html - Issue 366853008: [screen-orientation] Expose orientation info in OrientationInformation interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/screen_orientation/page-visibility.html

Issue 366853008: [screen-orientation] Expose orientation info in OrientationInformation interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: review comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/screen_orientation/orientationchange-event-subframe.html ('k') | LayoutTests/screen_orientation/resources/iframe-listen-orientation-change.html » ('j') | Source/modules/screen_orientation/OrientationInformation.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/screen_orientation/page-visibility.html

diff --git a/LayoutTests/screen_orientation/page-visibility.html b/LayoutTests/screen_orientation/page-visibility.html

index 8a1517d6ba6be0f22291009cc1a90b9c91eae176..2ffbb3ddbe656410b93a881f4f551e9cd706dc9b 100644

--- a/LayoutTests/screen_orientation/page-visibility.html

+++ b/LayoutTests/screen_orientation/page-visibility.html

@@ -21,7 +21,7 @@ test(function() {

if (window.testRunner)

window.testRunner.setMockScreenOrientation("landscape-primary");

assert_equals(orientationChangeEventListenerCalls, 1);

- assert_equals(screen.orientation, "landscape-primary");

+ assert_equals(screen.orientation.type, "landscape-primary");

}, "Test that 'orientationchange' event is fired when the page is visible");

if (window.testRunner)

@@ -35,7 +35,7 @@ test(function() {

}, "Test that 'orientationchange' event is not fired when the page is not visible");

test(function() {

- assert_equals(screen.orientation, "landscape-primary");

+ assert_equals(screen.orientation.type, "landscape-primary");

}, "Test that screen.orientation keeps returning the same orientation when the page is not visible");

if (window.testRunner)

@@ -46,7 +46,7 @@ test(function() {

// An 'orientationchange' event should have been fired.

assert_equals(orientationChangeEventListenerCalls, 2);

// Should keep returning the start returning the orientation value.

- assert_equals(screen.orientation, "portrait-primary");

+ assert_equals(screen.orientation.type, "portrait-primary");

}, "Test that screen.orientation is updated once the page is visible again");

test(function() {