LayoutTests/screen_orientation/orientationchange-event-subframe.html - Issue 366853008: [screen-orientation] Expose orientation info in OrientationInformation interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/screen_orientation/orientationchange-event-subframe.html

Issue 366853008: [screen-orientation] Expose orientation info in OrientationInformation interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: review comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/screen_orientation/orientationchange-event.html ('k') | LayoutTests/screen_orientation/page-visibility.html » ('j') | Source/modules/screen_orientation/OrientationInformation.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/screen_orientation/orientationchange-event-subframe.html

diff --git a/LayoutTests/screen_orientation/orientationchange-event-subframe.html b/LayoutTests/screen_orientation/orientationchange-event-subframe.html

index f64053f0c4c1ec2702d39b862c7f673abff03213..be30f77ec8f0b517b7bc7a1509618533bd015269 100644

--- a/LayoutTests/screen_orientation/orientationchange-event-subframe.html

+++ b/LayoutTests/screen_orientation/orientationchange-event-subframe.html

@@ -17,7 +17,7 @@

'landscape-secondary'

];

- var currentIndex = orientations.indexOf(window.screen.orientation);

+ var currentIndex = orientations.indexOf(window.screen.orientation.type);

var eventsReceived = 0;

function getNextIndex() {