Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: tests/lib/async/catch_errors17_test.dart

Issue 366813005: Don't consider controller.addError to be a zone-crossing. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: More tests. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/async/stream_impl.dart ('k') | tests/lib/async/catch_errors23_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/async/catch_errors17_test.dart
diff --git a/tests/lib/async/catch_errors17_test.dart b/tests/lib/async/catch_errors17_test.dart
index b57173240df4328a7dd95092589a889b118c0849..b9cffca2e6257df613e3eb98262f60f667edd68c 100644
--- a/tests/lib/async/catch_errors17_test.dart
+++ b/tests/lib/async/catch_errors17_test.dart
@@ -27,20 +27,20 @@ main() {
.listen((x) { events.add("stream $x"); });
}).listen((x) { events.add(x); });
controller.add(1);
- // Errors are not allowed to traverse boundaries. This error should be
- // caught by the outer catchErrors.
controller.addError(2);
+ new Future.error("outer error");
controller.close();
}).listen((x) {
events.add("outer: $x");
- if (x == 2) done.complete(true);
+ if (x == "outer error") done.complete(true);
}, onDone: () { Expect.fail("Unexpected callback"); });
done.future.whenComplete(() {
Timer.run(() {
Expect.listEquals(["map 1",
- "stream 101",
- "outer: 2",
+ "stream 101",
+ "stream error 2",
+ "outer: outer error",
],
events);
asyncEnd();
« no previous file with comments | « sdk/lib/async/stream_impl.dart ('k') | tests/lib/async/catch_errors23_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698