Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: sdk/lib/async/stream_impl.dart

Issue 366813005: Don't consider controller.addError to be a zone-crossing. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: More tests. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/lib/async/catch_errors17_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/async/stream_impl.dart
diff --git a/sdk/lib/async/stream_impl.dart b/sdk/lib/async/stream_impl.dart
index 0133f68128c9d49de29dfbf3d31ce2cf73fe0c8b..20314c88a17d5170ab621f7ea4ce5d5ce4a46823 100644
--- a/sdk/lib/async/stream_impl.dart
+++ b/sdk/lib/async/stream_impl.dart
@@ -354,10 +354,7 @@ class _BufferingStreamSubscription<T> implements StreamSubscription<T>,
// future to finish we must not report the error.
if (_isCanceled && !_waitsForCancel) return;
_state |= _STATE_IN_CALLBACK;
- if (!_zone.inSameErrorZone(Zone.current)) {
- // Errors are not allowed to traverse zone boundaries.
- Zone.current.handleUncaughtError(error, stackTrace);
- } else if (_onError is ZoneBinaryCallback) {
+ if (_onError is ZoneBinaryCallback) {
_zone.runBinaryGuarded(_onError, error, stackTrace);
} else {
_zone.runUnaryGuarded(_onError, error);
« no previous file with comments | « no previous file | tests/lib/async/catch_errors17_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698