Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Unified Diff: gyp/opts.gyp

Issue 366593004: Add SSE4 version of BlurImage optimizations. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Trying to set mac-flags to sse4 Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/opts/SkBlurImage_opts_SSE2.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/opts.gyp
diff --git a/gyp/opts.gyp b/gyp/opts.gyp
index 85c8c503fabbac5e766976c470528e19734bfd5a..6d7f273762d3481e9f6fb68e81accec9130de7b0 100644
--- a/gyp/opts.gyp
+++ b/gyp/opts.gyp
@@ -217,6 +217,14 @@
'cflags': [
'-msse4',
],
+ 'OTHER_CPLUSPLUSFLAGS': [
mtklein 2014/07/01 16:41:20 I think you will need to nest it inside 'xcode_set
henrik.smiding 2014/07/02 12:55:14 I'll try that!
+ '-msse4',
+ ],
mtklein 2014/07/01 16:41:20 If that doesn't work, try also adding 'OTHER_CPLU
henrik.smiding 2014/07/02 12:55:14 I tried that in Patch set #4. Not nested in xcode_
+ }],
+ [ 'skia_arch_type == "x86"', {
+ 'sources': [
+ '../src/opts/SkBlurImage_opts_SSE4.cpp',
+ ],
}],
[ 'skia_arch_width == 64 and skia_arch_type == "x86"', {
'sources': [
« no previous file with comments | « no previous file | src/opts/SkBlurImage_opts_SSE2.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698