Add SSE4 version of BlurImage optimizations.

gyp/opts.gyp

 # Gyp file for opts projects
 {
   'targets': [
     # Due to an unfortunate intersection of lameness between gcc and gyp,
     # we have to build the *_SSE2.cpp files in a separate target.  The
     # gcc lameness is that, in order to compile SSE2 intrinsics code, it
     # must be passed the -msse2 flag.  However, with this flag, it may
     # emit SSE2 instructions even for scalar code, such as the CPUID
     # test used to test for the presence of SSE2.  So that, and all other
     # code must be compiled *without* -msse2.  The gyp lameness is that it
@@ skipping 199 matching lines @@
       ],
       'include_dirs': [
         '../src/core',
       ],
       'conditions': [
         [ 'skia_os in ["linux", "freebsd", "openbsd", "solaris", "nacl", "chromeos", "android", "mac"] \
            and not skia_android_framework', {
           'cflags': [
             '-msse4',
           ],
+          'OTHER_CPLUSPLUSFLAGS': [

[mtklein, 2014/07/01 16:41:20]

I think you will need to nest it inside 'xcode_settings':

'xcode_settings': {
  'OTHER_CPLUSPLUSFLAGS': [ '-msse4' ],
},

GYP is really weird.

[henrik.smiding, 2014/07/02 12:55:14]

I'll try that!

+            '-msse4',
+          ],

[mtklein, 2014/07/01 16:41:20]

If that doesn't work, try also adding

'OTHER_CPLUSPLUSFLAGS!': [ '-mssse3' ],

?

The ! at the end makes it a negative merge... should remove -mssse3 from the
commandline.

[henrik.smiding, 2014/07/02 12:55:14]

I tried that in Patch set #4. Not nested in xcode_settings though.

+        }],
+        [ 'skia_arch_type == "x86"', {
+          'sources': [
+            '../src/opts/SkBlurImage_opts_SSE4.cpp',
+          ],
         }],
         [ 'skia_arch_width == 64 and skia_arch_type == "x86"', {
           'sources': [
             '../src/opts/SkBlitRow_opts_SSE4_x64_asm.S',
           ],
         }],
         [ 'skia_arch_width == 32 and skia_arch_type == "x86"', {
           'sources': [
             '../src/opts/SkBlitRow_opts_SSE4_asm.S',
           ],
@@ skipping 43 matching lines @@
         '../src/opts/SkBitmapProcState_matrix_neon.h',
         '../src/opts/SkBlitMask_opts_arm_neon.cpp',
         '../src/opts/SkBlitRow_opts_arm_neon.cpp',
         '../src/opts/SkBlurImage_opts_neon.cpp',
         '../src/opts/SkMorphology_opts_neon.cpp',
         '../src/opts/SkXfermode_opts_arm_neon.cpp',
       ],
     },
   ],
 }