Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 366583006: BuildGrowElementsCapacity bounds check used wrong elements kind. (Closed)

Created:
6 years, 5 months ago by mvstanton
Modified:
6 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

BuildGrowElementsCapacity bounds check used wrong elements kind. In a refactoring, HGraphBuilder::BuildGrowElementsCapacity() ended up using the old_elements_kind instead of new_kind when calculating if a new capacity for an array exceeds Page::kMaxRegularHeapObjectSize. Repair, such that the check is correct. R=hpayer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=22126

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Hannes, PTALz, thx! --Michael
6 years, 5 months ago (2014-07-01 12:50:15 UTC) #1
Hannes Payer (out of office)
lgtm
6 years, 5 months ago (2014-07-01 12:54:11 UTC) #2
mvstanton
6 years, 5 months ago (2014-07-01 14:52:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22126 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698