src/hydrogen.cc - Issue 366583006: BuildGrowElementsCapacity bounds check used wrong elements kind.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 366583006: BuildGrowElementsCapacity bounds check used wrong elements kind. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index 0651e71a081873c57e8399cd2681853415368804..f2dfe7de189ad7d18965111f2f4bb7f328c4035c 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -2683,7 +2683,7 @@ HValue* HGraphBuilder::BuildGrowElementsCapacity(HValue* object,

HValue* new_capacity) {

Add<HBoundsCheck>(new_capacity, Add<HConstant>(

(Page::kMaxRegularHeapObjectSize - FixedArray::kHeaderSize) >>

- ElementsKindToShiftSize(kind)));

+ ElementsKindToShiftSize(new_kind)));

HValue* new_elements = BuildAllocateElementsAndInitializeElementsHeader(

new_kind, new_capacity);

« no previous file with comments | « no previous file | no next file » | no next file with comments »