Issue 366583002: X87: KeyedLoadIC should have same register spec as LoadIC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 366583002: X87: KeyedLoadIC should have same register spec as LoadIC. (Closed)

Created:
6 years, 5 months ago by chunyang.dai

Modified:
6 years, 5 months ago

Reviewers:
Weiliang, mvstanton

CC:
v8-dev, danno

Base URL:
https://github.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

More Reviews

Description

X87: KeyedLoadIC should have same register spec as LoadIC. port r22103. original commit message: On arm, arm64 and x64 there is a different register specification between LoadIC and KeyedLoadIC. It would be nicer if these are the same, allowing some key optimizations. BUG=

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+91 lines, -117 lines)			Patch
M	src/x87/builtins-x87.cc	View	2 chunks	+10 lines, -8 lines	0 comments	Download
M	src/x87/debug-x87.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/x87/full-codegen-x87.cc	View	9 chunks	+28 lines, -37 lines	0 comments	Download
M	src/x87/ic-x87.cc	View	10 chunks	+44 lines, -61 lines	0 comments	Download
M	src/x87/lithium-codegen-x87.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/x87/lithium-x87.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/x87/stub-cache-x87.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Committed as r22122

Expand Messages | Collapse Messages