Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: src/x87/stub-cache-x87.cc

Issue 366583002: X87: KeyedLoadIC should have same register spec as LoadIC. (Closed) Base URL: https://github.com/v8/v8.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x87/lithium-x87.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X87 7 #if V8_TARGET_ARCH_X87
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/ic-inl.h" 10 #include "src/ic-inl.h"
(...skipping 1273 matching lines...) Expand 10 before | Expand all | Expand 10 after
1284 // receiver, name, scratch1, scratch2, scratch3, scratch4. 1284 // receiver, name, scratch1, scratch2, scratch3, scratch4.
1285 Register receiver = LoadIC::ReceiverRegister(); 1285 Register receiver = LoadIC::ReceiverRegister();
1286 Register name = LoadIC::NameRegister(); 1286 Register name = LoadIC::NameRegister();
1287 static Register registers[] = { receiver, name, ebx, eax, edi, no_reg }; 1287 static Register registers[] = { receiver, name, ebx, eax, edi, no_reg };
1288 return registers; 1288 return registers;
1289 } 1289 }
1290 1290
1291 1291
1292 Register* KeyedLoadStubCompiler::registers() { 1292 Register* KeyedLoadStubCompiler::registers() {
1293 // receiver, name, scratch1, scratch2, scratch3, scratch4. 1293 // receiver, name, scratch1, scratch2, scratch3, scratch4.
1294 Register receiver = KeyedLoadIC::ReceiverRegister(); 1294 Register receiver = LoadIC::ReceiverRegister();
1295 Register name = KeyedLoadIC::NameRegister(); 1295 Register name = LoadIC::NameRegister();
1296 static Register registers[] = { receiver, name, ebx, eax, edi, no_reg }; 1296 static Register registers[] = { receiver, name, ebx, eax, edi, no_reg };
1297 return registers; 1297 return registers;
1298 } 1298 }
1299 1299
1300 1300
1301 Register StoreStubCompiler::value() { 1301 Register StoreStubCompiler::value() {
1302 return eax; 1302 return eax;
1303 } 1303 }
1304 1304
1305 1305
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
1446 #define __ ACCESS_MASM(masm) 1446 #define __ ACCESS_MASM(masm)
1447 1447
1448 1448
1449 void KeyedLoadStubCompiler::GenerateLoadDictionaryElement( 1449 void KeyedLoadStubCompiler::GenerateLoadDictionaryElement(
1450 MacroAssembler* masm) { 1450 MacroAssembler* masm) {
1451 // ----------- S t a t e ------------- 1451 // ----------- S t a t e -------------
1452 // -- ecx : key 1452 // -- ecx : key
1453 // -- edx : receiver 1453 // -- edx : receiver
1454 // -- esp[0] : return address 1454 // -- esp[0] : return address
1455 // ----------------------------------- 1455 // -----------------------------------
1456 ASSERT(edx.is(KeyedLoadIC::ReceiverRegister())); 1456 ASSERT(edx.is(LoadIC::ReceiverRegister()));
1457 ASSERT(ecx.is(KeyedLoadIC::NameRegister())); 1457 ASSERT(ecx.is(LoadIC::NameRegister()));
1458 Label slow, miss; 1458 Label slow, miss;
1459 1459
1460 // This stub is meant to be tail-jumped to, the receiver must already 1460 // This stub is meant to be tail-jumped to, the receiver must already
1461 // have been verified by the caller to not be a smi. 1461 // have been verified by the caller to not be a smi.
1462 __ JumpIfNotSmi(ecx, &miss); 1462 __ JumpIfNotSmi(ecx, &miss);
1463 __ mov(ebx, ecx); 1463 __ mov(ebx, ecx);
1464 __ SmiUntag(ebx); 1464 __ SmiUntag(ebx);
1465 __ mov(eax, FieldOperand(edx, JSObject::kElementsOffset)); 1465 __ mov(eax, FieldOperand(edx, JSObject::kElementsOffset));
1466 1466
1467 // Push receiver on the stack to free up a register for the dictionary 1467 // Push receiver on the stack to free up a register for the dictionary
(...skipping 22 matching lines...) Expand all
1490 // ----------------------------------- 1490 // -----------------------------------
1491 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 1491 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
1492 } 1492 }
1493 1493
1494 1494
1495 #undef __ 1495 #undef __
1496 1496
1497 } } // namespace v8::internal 1497 } } // namespace v8::internal
1498 1498
1499 #endif // V8_TARGET_ARCH_X87 1499 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/x87/lithium-x87.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698