Chromium Code Reviews| Index: tests/standalone/io/http_client_connect_test.dart |
| diff --git a/tests/standalone/io/http_client_connect_test.dart b/tests/standalone/io/http_client_connect_test.dart |
| index 3c5b88b4c36f927713555ed0636dd1a44eb46592..732bf45bc46530e975027bea49fd9ff1f8735dc9 100644 |
| --- a/tests/standalone/io/http_client_connect_test.dart |
| +++ b/tests/standalone/io/http_client_connect_test.dart |
| @@ -68,46 +68,16 @@ void testGetServerClose() { |
| HttpServer.bind("127.0.0.1", 0).then((server) { |
| server.listen((request) { |
| server.close(); |
| + new Timer(const Duration(milliseconds: 100), () { |
| + request.response.close(); |
| + }); |
| }); |
| var client = new HttpClient(); |
| client.get("127.0.0.1", server.port, "/") |
| .then((request) => request.close()) |
| - .then((response) { |
| - Expect.fail("Request not expected"); |
| - }) |
| - .catchError((error) => asyncEnd(), |
| - test: (error) => error is HttpException); |
| - }); |
| -} |
| - |
| -void testGetDataServerClose() { |
|
Søren Gjesse
2013/10/23 08:14:05
This test is removed because there is no forceful
Anders Johnsen
2013/10/23 10:23:24
Agreed. Let me know what you think about the `forc
|
| - asyncStart(); |
| - var completer = new Completer(); |
| - HttpServer.bind("127.0.0.1", 0).then((server) { |
| - server.listen((request) { |
| - request.response.contentLength = 100; |
| - request.response.write("data"); |
| - request.response.write("more data"); |
| - completer.future.then((_) => server.close()); |
| - }); |
| - |
| - var client = new HttpClient(); |
| - client.get("127.0.0.1", server.port, "/") |
| - .then((request) => request.close()) |
| - .then((response) { |
| - // Close the (incomplete) response, now that we have seen |
| - // the response object. |
| - completer.complete(null); |
| - int errors = 0; |
| - response.listen( |
| - (data) {}, |
| - onError: (error) => errors++, |
| - onDone: () { |
| - Expect.equals(1, errors); |
| - asyncEnd(); |
| - }); |
| - }); |
| + .then((response) => response.drain()) |
| + .then((_) => asyncEnd()); |
| }); |
| } |
| @@ -132,6 +102,5 @@ void main() { |
| testGetDataRequest(); |
| testGetInvalidHost(); |
| testGetServerClose(); |
| - testGetDataServerClose(); |
| testPostEmptyRequest(); |
| } |