Don't close existing connection on HttpServer close (and stream cancel).

tests/standalone/io/http_client_connect_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // VMOptions=
 // VMOptions=--short_socket_read
 // VMOptions=--short_socket_write
 // VMOptions=--short_socket_read --short_socket_write
 
 import 'dart:async';
@@ skipping 50 matching lines @@
       client.close();
       asyncEnd();
     });
 }
 
 void testGetServerClose() {
   asyncStart();
   HttpServer.bind("127.0.0.1", 0).then((server) {
     server.listen((request) {
       server.close();
+      new Timer(const Duration(milliseconds: 100), () {
+        request.response.close();
+      });
     });
 
     var client = new HttpClient();
     client.get("127.0.0.1", server.port, "/")
       .then((request) => request.close())
-      .then((response) {
-        Expect.fail("Request not expected");
-      })
-        .catchError((error) => asyncEnd(),
-                    test: (error) => error is HttpException);
+      .then((response) => response.drain())
+      .then((_) => asyncEnd());
   });
 }
 
-void testGetDataServerClose() {

[Søren Gjesse, 2013/10/23 08:14:05]

This test is removed because there is no forceful server shutdown. Adding that
back should make it possible to keep this test.

[Anders Johnsen, 2013/10/23 10:23:24]

Agreed. Let me know what you think about the `force` flag.

-  asyncStart();
-  var completer = new Completer();
-  HttpServer.bind("127.0.0.1", 0).then((server) {
-    server.listen((request) {
-      request.response.contentLength = 100;
-      request.response.write("data");
-      request.response.write("more data");
-      completer.future.then((_) => server.close());
-    });
-
-    var client = new HttpClient();
-    client.get("127.0.0.1", server.port, "/")
-      .then((request) => request.close())
-      .then((response) {
-        // Close the (incomplete) response, now that we have seen
-        // the response object.
-        completer.complete(null);
-        int errors = 0;
-        response.listen(
-          (data) {},
-          onError: (error) => errors++,
-          onDone: () {
-            Expect.equals(1, errors);
-            asyncEnd();
-          });
-      });
-  });
-}
-
 void testPostEmptyRequest() {
   HttpServer.bind("127.0.0.1", 0).then((server) {
     server.listen((request) {
       request.pipe(request.response);
     });
 
     var client = new HttpClient();
     client.post("127.0.0.1", server.port, "/")
       .then((request) => request.close())
       .then((response) {
         response.listen((data) {}, onDone: server.close);
       });
   });
 }
 
 
 void main() {
   testGetEmptyRequest();
   testGetDataRequest();
   testGetInvalidHost();
   testGetServerClose();
-  testGetDataServerClose();
   testPostEmptyRequest();
 }