Issue 366323002: Push API: use an enum to indicate status.

Issue 366323002: Push API: use an enum to indicate status. (Closed)

Created:
6 years, 5 months ago by Michael van Ouwerkerk

Modified:
6 years, 5 months ago

Reviewers:
johnme, palmer, jochen (gone - plz use gerrit)

CC:
chromium-reviews, darin-cc_chromium.org, jam, Peter Beverloo, zea+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Push API: use an enum to indicate status. BUG=350377 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282348

Patch Set 1 #

Patch Set 2 : Rebase. Tweak mock error message. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+155 lines, -35 lines)			Patch
M	chrome/browser/services/gcm/push_messaging_service_impl.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/services/gcm/push_messaging_service_impl.cc	View		4 chunks	+31 lines, -10 lines	0 comments	Download
M	content/browser/push_messaging_message_filter.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	content/browser/push_messaging_message_filter.cc	View		3 chunks	+12 lines, -5 lines	0 comments	Download
M	content/common/push_messaging_messages.h	View		2 chunks	+7 lines, -2 lines	0 comments	Download
M	content/content_common.gypi	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/public/browser/push_messaging_service.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
A	content/public/common/push_messaging_status.h	View		1 chunk	+41 lines, -0 lines	0 comments	Download
A	content/public/common/push_messaging_status.cc	View		1 chunk	+38 lines, -0 lines	0 comments	Download
M	content/renderer/push_messaging_dispatcher.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	content/renderer/push_messaging_dispatcher.cc	View	1	3 chunks	+9 lines, -12 lines	0 comments	Download
M	content/shell/renderer/test_runner/mock_web_push_client.cc	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 15 (0 generated)

Expand Messages | Collapse Messages

Michael van Ouwerkerk

John, could you please review this from a feature perspective?

6 years, 5 months ago (2014-07-04 12:51:29 UTC) #1

Michael van Ouwerkerk

jam: could you please take a look as owner?

6 years, 5 months ago (2014-07-08 17:05:08 UTC) #3

Michael van Ouwerkerk

Chris: could you please take a look at push_messaging_messages.h ?

6 years, 5 months ago (2014-07-08 17:05:53 UTC) #4

Michael van Ouwerkerk

-jam as he seems to be OOO for the rest of the week Jochen, could ...

6 years, 5 months ago (2014-07-09 16:34:52 UTC) #6

Michael van Ouwerkerk

The CQ bit was checked by mvanouwerkerk@chromium.org

6 years, 5 months ago (2014-07-10 11:28:55 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/366323002/20001

6 years, 5 months ago (2014-07-10 11:29:50 UTC) #10

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...

6 years, 5 months ago (2014-07-10 12:53:33 UTC) #11

Michael van Ouwerkerk

The CQ bit was unchecked by mvanouwerkerk@chromium.org

6 years, 5 months ago (2014-07-10 16:03:01 UTC) #12

Michael van Ouwerkerk

The CQ bit was checked by mvanouwerkerk@chromium.org

6 years, 5 months ago (2014-07-10 16:03:04 UTC) #13

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/366323002/20001

6 years, 5 months ago (2014-07-10 16:03:52 UTC) #14

Message was sent while issue was closed.

Change committed as 282348

Expand Messages | Collapse Messages