content/common/push_messaging_messages.h - Issue 366323002: Push API: use an enum to indicate status.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/push_messaging_messages.h

Issue 366323002: Push API: use an enum to indicate status. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase. Tweak mock error message. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/push_messaging_messages.h

diff --git a/content/common/push_messaging_messages.h b/content/common/push_messaging_messages.h

index 29d8f80de8dcdcbab4c252e49d40120fdd8d1de1..cd5e93edb7b8531764e060fd7c70f7f187127089 100644

--- a/content/common/push_messaging_messages.h

+++ b/content/common/push_messaging_messages.h

@@ -5,11 +5,15 @@

// IPC messages for push messaging.

// Multiply-included message file, hence no include guard.

+#include "content/public/common/push_messaging_status.h"

#include "ipc/ipc_message_macros.h"

#include "url/gurl.h"

#define IPC_MESSAGE_START PushMessagingMsgStart

+IPC_ENUM_TRAITS_MAX_VALUE(content::PushMessagingStatus,

+ content::PUSH_MESSAGING_STATUS_LAST)

// Messages sent from the browser to the renderer.

IPC_MESSAGE_ROUTED3(PushMessagingMsg_RegisterSuccess,

@@ -17,8 +21,9 @@ IPC_MESSAGE_ROUTED3(PushMessagingMsg_RegisterSuccess,

GURL /* push_endpoint */,

std::string /* push_registration_id */)

-IPC_MESSAGE_ROUTED1(PushMessagingMsg_RegisterError,

- int32 /* callbacks_id */)

+IPC_MESSAGE_ROUTED2(PushMessagingMsg_RegisterError,

+ int32 /* callbacks_id */,

+ content::PushMessagingStatus /* status */)

// Messages sent from the renderer to the browser.

« no previous file with comments | « content/browser/push_messaging_message_filter.cc ('k') | content/content_common.gypi » ('j') | no next file with comments »