LayoutTests/fast/dom/TreeWalker/TreeWalker-basic.html - Issue 366223006: createTreeWalker and createNodeIterator should deal with null NodeFilter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/TreeWalker/TreeWalker-basic.html

Issue 366223006: createTreeWalker and createNodeIterator should deal with null NodeFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take review comment into consideration Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/NodeIterator/NodeIterator-basic-expected.txt ('k') | LayoutTests/fast/dom/TreeWalker/TreeWalker-basic-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/TreeWalker/TreeWalker-basic.html

diff --git a/LayoutTests/fast/dom/TreeWalker/TreeWalker-basic.html b/LayoutTests/fast/dom/TreeWalker/TreeWalker-basic.html

index e89838692e011176b3445a1bb9674e1daf8875c5..2bdb92253fa4020322754342501c1260ad17c75c 100644

--- a/LayoutTests/fast/dom/TreeWalker/TreeWalker-basic.html

+++ b/LayoutTests/fast/dom/TreeWalker/TreeWalker-basic.html

@@ -119,6 +119,14 @@ test(function ()

assert_false(walker.expandEntityReferences);

});

}, 'Test that the fourth argument (expandEntityReferences) is ignored.');

+test(function() {

+ var tw = document.createTreeWalker(document.body, 42, null);

haraken 2014/07/05 02:02:11 Nit: tw => treeWalker Blink prefers a fully quali

kangil_ 2014/07/05 02:10:49 Done.

+ assert_equals(tw.root, document.body);

+ assert_equals(tw.currentNode, document.body);

+ assert_equals(tw.whatToShow, 42);

+ assert_equals(tw.filter, null);

+}, "Optional arguments to createTreeWalker should be optional (3 passed, null).");

</script>

</body>

</html>