LayoutTests/fast/dom/TreeWalker/TreeWalker-basic-expected.txt - Issue 366223006: createTreeWalker and createNodeIterator should deal with null NodeFilter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/TreeWalker/TreeWalker-basic-expected.txt

Issue 366223006: createTreeWalker and createNodeIterator should deal with null NodeFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take review comment into consideration Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/dom/TreeWalker/TreeWalker-basic.html ('K') | « LayoutTests/fast/dom/TreeWalker/TreeWalker-basic.html ('k') | Source/bindings/core/v8/V8Binding.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/TreeWalker/TreeWalker-basic-expected.txt

diff --git a/LayoutTests/fast/dom/TreeWalker/TreeWalker-basic-expected.txt b/LayoutTests/fast/dom/TreeWalker/TreeWalker-basic-expected.txt

index 1665860d3c07cd49aacd8e207fa0b7fe04929f99..a7327230a0a864ef2b9d2c5ffb7d45ef5aeb7851 100644

--- a/LayoutTests/fast/dom/TreeWalker/TreeWalker-basic-expected.txt

+++ b/LayoutTests/fast/dom/TreeWalker/TreeWalker-basic-expected.txt

@@ -6,5 +6,6 @@ PASS Construct a TreeWalker by document.createTreeWalker().

PASS Give an invalid root node to document.createTreeWalker().

PASS Walk over nodes.

PASS Test that the fourth argument (expandEntityReferences) is ignored.

+PASS Optional arguments to createTreeWalker should be optional (3 passed, null).

Harness: the test ran to completion.