Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: cc/resources/tile_manager.h

Issue 366113002: cc: Do not cleanup tiles with raster tasks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/resources/tile_manager.cc » ('j') | cc/resources/tile_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/tile_manager.h
diff --git a/cc/resources/tile_manager.h b/cc/resources/tile_manager.h
index 5ad80910f8e8aed434edc19e2a04571ce3d62781..59a8864e49b70edb246eaf959705ae95fb5b00ac 100644
--- a/cc/resources/tile_manager.h
+++ b/cc/resources/tile_manager.h
@@ -227,7 +227,10 @@ class CC_EXPORT TileManager : public RasterizerClient,
void SetRasterizerForTesting(Rasterizer* rasterizer);
- void CleanUpReleasedTilesForTesting() { CleanUpReleasedTiles(); }
+ void FreeResourcesAndCleanUpReleasedTilesForTesting() {
+ FreeResourcesForReleasedTiles();
+ CleanUpReleasedTiles();
+ }
protected:
TileManager(TileManagerClient* client,
@@ -240,6 +243,9 @@ class CC_EXPORT TileManager : public RasterizerClient,
friend class Tile;
void DidChangeTilePriority(Tile* tile);
+ bool TileHasRasterTask(Tile* tile);
reveman 2014/07/11 17:06:36 does this have to be a member function? please mov
sohanjg 2014/07/12 11:41:59 Looks like, managed_state and raster_task_ used in
reveman 2014/07/14 21:55:00 Ok, just make it static and private then unless th
sohanjg 2014/07/15 05:36:37 Done.
+
+ void FreeResourcesForReleasedTiles();
void CleanUpReleasedTiles();
// Overriden from RefCountedManager<Tile>:
@@ -331,8 +337,6 @@ class CC_EXPORT TileManager : public RasterizerClient,
// Queue used when scheduling raster tasks.
RasterTaskQueue raster_queue_;
- std::vector<scoped_refptr<RasterTask> > orphan_raster_tasks_;
-
UniqueNotifier ready_to_activate_check_notifier_;
DISALLOW_COPY_AND_ASSIGN(TileManager);
« no previous file with comments | « no previous file | cc/resources/tile_manager.cc » ('j') | cc/resources/tile_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698