Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Side by Side Diff: cc/resources/tile_manager.h

Issue 366113002: cc: Do not cleanup tiles with raster tasks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | cc/resources/tile_manager.cc » ('j') | cc/resources/tile_manager.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_RESOURCES_TILE_MANAGER_H_ 5 #ifndef CC_RESOURCES_TILE_MANAGER_H_
6 #define CC_RESOURCES_TILE_MANAGER_H_ 6 #define CC_RESOURCES_TILE_MANAGER_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <set> 10 #include <set>
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 // Soft limit is used for resource pool such that 220 // Soft limit is used for resource pool such that
221 // memory returns to soft limit after going over. 221 // memory returns to soft limit after going over.
222 if (state != global_state_) { 222 if (state != global_state_) {
223 global_state_ = state; 223 global_state_ = state;
224 prioritized_tiles_dirty_ = true; 224 prioritized_tiles_dirty_ = true;
225 } 225 }
226 } 226 }
227 227
228 void SetRasterizerForTesting(Rasterizer* rasterizer); 228 void SetRasterizerForTesting(Rasterizer* rasterizer);
229 229
230 void CleanUpReleasedTilesForTesting() { CleanUpReleasedTiles(); } 230 void FreeResourcesAndCleanUpReleasedTilesForTesting() {
231 FreeResourcesForReleasedTiles();
232 CleanUpReleasedTiles();
233 }
231 234
232 protected: 235 protected:
233 TileManager(TileManagerClient* client, 236 TileManager(TileManagerClient* client,
234 base::SequencedTaskRunner* task_runner, 237 base::SequencedTaskRunner* task_runner,
235 ResourcePool* resource_pool, 238 ResourcePool* resource_pool,
236 Rasterizer* rasterizer, 239 Rasterizer* rasterizer,
237 RenderingStatsInstrumentation* rendering_stats_instrumentation); 240 RenderingStatsInstrumentation* rendering_stats_instrumentation);
238 241
239 // Methods called by Tile 242 // Methods called by Tile
240 friend class Tile; 243 friend class Tile;
241 void DidChangeTilePriority(Tile* tile); 244 void DidChangeTilePriority(Tile* tile);
242 245
246 bool TileHasRasterTask(Tile* tile);
reveman 2014/07/11 17:06:36 does this have to be a member function? please mov
sohanjg 2014/07/12 11:41:59 Looks like, managed_state and raster_task_ used in
reveman 2014/07/14 21:55:00 Ok, just make it static and private then unless th
sohanjg 2014/07/15 05:36:37 Done.
247
248 void FreeResourcesForReleasedTiles();
243 void CleanUpReleasedTiles(); 249 void CleanUpReleasedTiles();
244 250
245 // Overriden from RefCountedManager<Tile>: 251 // Overriden from RefCountedManager<Tile>:
246 virtual void Release(Tile* tile) OVERRIDE; 252 virtual void Release(Tile* tile) OVERRIDE;
247 253
248 // Overriden from RasterizerClient: 254 // Overriden from RasterizerClient:
249 virtual bool ShouldForceTasksRequiredForActivationToComplete() const OVERRIDE; 255 virtual bool ShouldForceTasksRequiredForActivationToComplete() const OVERRIDE;
250 virtual void DidFinishRunningTasks() OVERRIDE; 256 virtual void DidFinishRunningTasks() OVERRIDE;
251 virtual void DidFinishRunningTasksRequiredForActivation() OVERRIDE; 257 virtual void DidFinishRunningTasksRequiredForActivation() OVERRIDE;
252 258
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
324 330
325 RasterTaskCompletionStats update_visible_tiles_stats_; 331 RasterTaskCompletionStats update_visible_tiles_stats_;
326 332
327 std::vector<Tile*> released_tiles_; 333 std::vector<Tile*> released_tiles_;
328 334
329 ResourceFormat resource_format_; 335 ResourceFormat resource_format_;
330 336
331 // Queue used when scheduling raster tasks. 337 // Queue used when scheduling raster tasks.
332 RasterTaskQueue raster_queue_; 338 RasterTaskQueue raster_queue_;
333 339
334 std::vector<scoped_refptr<RasterTask> > orphan_raster_tasks_;
335
336 UniqueNotifier ready_to_activate_check_notifier_; 340 UniqueNotifier ready_to_activate_check_notifier_;
337 341
338 DISALLOW_COPY_AND_ASSIGN(TileManager); 342 DISALLOW_COPY_AND_ASSIGN(TileManager);
339 }; 343 };
340 344
341 } // namespace cc 345 } // namespace cc
342 346
343 #endif // CC_RESOURCES_TILE_MANAGER_H_ 347 #endif // CC_RESOURCES_TILE_MANAGER_H_
OLDNEW
« no previous file with comments | « no previous file | cc/resources/tile_manager.cc » ('j') | cc/resources/tile_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698