Autofill: don't require POST method.

components/autofill/core/browser/form_structure.h

Index: components/autofill/core/browser/form_structure.h
diff --git a/components/autofill/core/browser/form_structure.h b/components/autofill/core/browser/form_structure.h
index 2192e12e4c72cd30074aad7ec35eb2ec33d8ceb7..7ff764edf6168023de1c5bbfeee1231018163044 100644
--- a/components/autofill/core/browser/form_structure.h
+++ b/components/autofill/core/browser/form_structure.h
@@ -20,11 +20,6 @@
 #include "components/autofill/core/common/web_element_descriptor.h"
 #include "url/gurl.h"
 
-enum RequestMethod {
-  GET,
-  POST
-};
-
 enum UploadRequired {
   UPLOAD_NOT_REQUIRED,
   UPLOAD_REQUIRED,
@@ -96,9 +91,8 @@ class FormStructure {
   std::string FormSignature() const;
 
   // Runs a quick heuristic to rule out forms that are obviously not
-  // auto-fillable, like google/yahoo/msn search, etc. The requirement that the
-  // form's method be POST is only applied if |require_method_post| is true.
-  bool IsAutofillable(bool require_method_post) const;
+  // auto-fillable, like google/yahoo/msn search, etc.
+  bool IsAutofillable() const;
 
   // Resets |autofill_count_| and counts the number of auto-fillable fields.
   // This is used when we receive server data for form fields.  At that time,
@@ -107,9 +101,7 @@ class FormStructure {
   void UpdateAutofillCount();
 
   // Returns true if this form matches the structural requirements for Autofill.
-  // The requirement that the form's method be POST is only applied if
-  // |require_method_post| is true.
-  bool ShouldBeParsed(bool require_method_post) const;
+  bool ShouldBeParsed() const;
 
   // Returns true if we should query the crowdsourcing server to determine this
   // form's field types.  If the form includes author-specified types, this will
@@ -254,8 +246,8 @@ class FormStructure {
   // to the stored upload rates.
   UploadRequired upload_required_;
 
-  // GET or POST.
-  RequestMethod method_;
+  // The method attribute on the form (e.g. POST or GET).
+  base::string16 method_;

[Ilya Sherman, 2014/07/15 03:21:24]

Hmm, it doesn't look like this is used -- can this be removed?

[Evan Stade, 2014/07/15 19:01:57]

Done.

 
   // Whether the form includes any field types explicitly specified by the site
   // author, via the |autocompletetype| attribute.