Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Unified Diff: Source/core/html/canvas/WebGLUniformLocation.h

Issue 365653002: Oilpan: move 2D Canvas and WebGL objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Have Nullable<T>::trace() use TraceIfNeeded<>. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/canvas/WebGLUniformLocation.h
diff --git a/Source/core/html/canvas/WebGLUniformLocation.h b/Source/core/html/canvas/WebGLUniformLocation.h
index aacde36379b185cd3237ccdb9fb4675fadabd8dc..2cd726f5bf3a8a233d7d42ffba84cb201ebc94c2 100644
--- a/Source/core/html/canvas/WebGLUniformLocation.h
+++ b/Source/core/html/canvas/WebGLUniformLocation.h
@@ -34,19 +34,21 @@
namespace WebCore {
-class WebGLUniformLocation FINAL : public RefCounted<WebGLUniformLocation>, public ScriptWrappable {
+class WebGLUniformLocation FINAL : public RefCountedWillBeGarbageCollectedFinalized<WebGLUniformLocation>, public ScriptWrappable {
bajones 2014/07/18 20:31:29 This also looks like it doesn't need Finalization
sof 2014/07/18 21:39:29 Indeed so, it doesn't need finalization. Thanks, w
sof 2014/07/19 19:55:57 Done.
public:
- static PassRefPtr<WebGLUniformLocation> create(WebGLProgram*, GLint location);
+ static PassRefPtrWillBeRawPtr<WebGLUniformLocation> create(WebGLProgram*, GLint location);
WebGLProgram* program() const;
GLint location() const;
+ void trace(Visitor*);
+
protected:
WebGLUniformLocation(WebGLProgram*, GLint location);
private:
- RefPtr<WebGLProgram> m_program;
+ RefPtrWillBeMember<WebGLProgram> m_program;
GLint m_location;
unsigned m_linkCount;
};

Powered by Google App Engine
This is Rietveld 408576698