Source/core/html/canvas/WebGLShader.cpp - Issue 365653002: Oilpan: move 2D Canvas and WebGL objects to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/canvas/WebGLShader.cpp

Issue 365653002: Oilpan: move 2D Canvas and WebGL objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Have Nullable<T>::trace() use TraceIfNeeded<>. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/canvas/WebGLRenderingContextBase.h ('K') | « Source/core/html/canvas/WebGLShader.h ('k') | Source/core/html/canvas/WebGLShader.idl » ('j') | Source/core/html/canvas/WebGLTexture.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/canvas/WebGLShader.cpp

diff --git a/Source/core/html/canvas/WebGLShader.cpp b/Source/core/html/canvas/WebGLShader.cpp

index 203041e85cf66c225b4cb8e2693f455b89f450e8..461169fab33fe0c3aacda03e5c3de0d4741cdef5 100644

--- a/Source/core/html/canvas/WebGLShader.cpp

+++ b/Source/core/html/canvas/WebGLShader.cpp

@@ -31,9 +31,9 @@

namespace WebCore {

-PassRefPtr<WebGLShader> WebGLShader::create(WebGLRenderingContextBase* ctx, GLenum type)

+PassRefPtrWillBeRawPtr<WebGLShader> WebGLShader::create(WebGLRenderingContextBase* ctx, GLenum type)

{

- return adoptRef(new WebGLShader(ctx, type));

+ return adoptRefWillBeNoop(new WebGLShader(ctx, type));

}

WebGLShader::WebGLShader(WebGLRenderingContextBase* ctx, GLenum type)

@@ -47,7 +47,7 @@ WebGLShader::WebGLShader(WebGLRenderingContextBase* ctx, GLenum type)

WebGLShader::~WebGLShader()

{

- deleteObject(0);

+ detachAndDeleteObject();

Ken Russell (switch to Gerrit) 2014/07/19 00:27:16 Please add a comment about the need to manually ca

sof 2014/07/19 19:55:57 Thanks, added.

}

void WebGLShader::deleteObjectImpl(blink::WebGraphicsContext3D* context3d, Platform3DObject object)