Source/core/html/canvas/WebGLContextGroup.h - Issue 365653002: Oilpan: move 2D Canvas and WebGL objects to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/canvas/WebGLContextGroup.h

Issue 365653002: Oilpan: move 2D Canvas and WebGL objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Have Nullable<T>::trace() use TraceIfNeeded<>. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/canvas/WebGLBuffer.cpp ('K') | « Source/core/html/canvas/WebGLContextAttributes.idl ('k') | Source/core/html/canvas/WebGLContextObject.h » ('j') | Source/core/html/canvas/WebGLFramebuffer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/canvas/WebGLContextGroup.h

diff --git a/Source/core/html/canvas/WebGLContextGroup.h b/Source/core/html/canvas/WebGLContextGroup.h

index 6c2f995354013332bda0e70ba332cefb2c2f7aec..7631e79b2e689c9e33af5af4af5531ea1587c2f8 100644

--- a/Source/core/html/canvas/WebGLContextGroup.h

+++ b/Source/core/html/canvas/WebGLContextGroup.h

@@ -58,13 +58,19 @@ public:

void loseContextGroup(WebGLRenderingContextBase::LostContextMode);

- private:

+private:

friend class WebGLObject;

WebGLContextGroup();

void detachAndRemoveAllObjects();

+ // FIXME: Oilpan: this object is not on the heap, but keeps bare

+ // pointers to garbage collected objects in the two hash sets

+ // below. The objects are responsible for managing their

+ // registration with WebGLContextGroup, and vice versa, the

+ // WebGLContextGroup takes care of detaching the group objects if

+ // the set of WebGLRenderingContextBase contexts becomes empty.

HashSet<WebGLRenderingContextBase*> m_contexts;

HashSet<WebGLSharedObject*> m_groupObjects;

};