Index: Source/core/html/canvas/WebGLContextGroup.h |
diff --git a/Source/core/html/canvas/WebGLContextGroup.h b/Source/core/html/canvas/WebGLContextGroup.h |
index 6c2f995354013332bda0e70ba332cefb2c2f7aec..7631e79b2e689c9e33af5af4af5531ea1587c2f8 100644 |
--- a/Source/core/html/canvas/WebGLContextGroup.h |
+++ b/Source/core/html/canvas/WebGLContextGroup.h |
@@ -58,13 +58,19 @@ public: |
void loseContextGroup(WebGLRenderingContextBase::LostContextMode); |
- private: |
+private: |
friend class WebGLObject; |
WebGLContextGroup(); |
void detachAndRemoveAllObjects(); |
+ // FIXME: Oilpan: this object is not on the heap, but keeps bare |
Mads Ager (chromium)
2014/07/11 06:47:23
Could you update the comment with the reason why w
sof
2014/07/11 09:42:02
It's covered in the review why this collection (an
Mads Ager (chromium)
2014/07/11 10:18:52
I guess my question boils down to whether or not t
sof
2014/07/14 11:47:53
That persistent reference would keep the rendering
sof
2014/07/14 13:58:45
Tried this locally & it works out.
The single-ren
|
+ // pointers to garbage collected objects in the two hash sets |
+ // below. The objects are responsible for managing their |
+ // registration with WebGLContextGroup, and vice versa, the |
+ // WebGLContextGroup takes care of detaching the group objects if |
+ // the set of WebGLRenderingContextBase contexts becomes empty. |
HashSet<WebGLRenderingContextBase*> m_contexts; |
Mads Ager (chromium)
2014/07/11 09:15:01
I think I might be confused, but based on my searc
|
HashSet<WebGLSharedObject*> m_groupObjects; |
}; |