Source/core/html/canvas/WebGLBuffer.cpp - Issue 365653002: Oilpan: move 2D Canvas and WebGL objects to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/canvas/WebGLBuffer.cpp

Issue 365653002: Oilpan: move 2D Canvas and WebGL objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Make WebGLObjects keep a blink::WebGraphicsContext3D for finalization. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/canvas/CanvasRenderingContext2D.cpp ('K') | « Source/core/html/canvas/WebGLBuffer.h ('k') | Source/core/html/canvas/WebGLBuffer.idl » ('j') | Source/core/html/canvas/WebGLContextGroup.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/canvas/WebGLBuffer.cpp

diff --git a/Source/core/html/canvas/WebGLBuffer.cpp b/Source/core/html/canvas/WebGLBuffer.cpp

index 6308eccf1922cc6d9b3322e0eec360307e87dc99..0c4d4724bf673d5ae13a57bb5f35d4af6f449dd3 100644

--- a/Source/core/html/canvas/WebGLBuffer.cpp

+++ b/Source/core/html/canvas/WebGLBuffer.cpp

@@ -31,9 +31,9 @@

namespace WebCore {

-PassRefPtr<WebGLBuffer> WebGLBuffer::create(WebGLRenderingContextBase* ctx)

+PassRefPtrWillBeRawPtr<WebGLBuffer> WebGLBuffer::create(WebGLRenderingContextBase* ctx)

{

- return adoptRef(new WebGLBuffer(ctx));

+ return adoptRefWillBeNoop(new WebGLBuffer(ctx));

}

WebGLBuffer::WebGLBuffer(WebGLRenderingContextBase* ctx)

@@ -46,6 +46,7 @@ WebGLBuffer::WebGLBuffer(WebGLRenderingContextBase* ctx)

WebGLBuffer::~WebGLBuffer()

{

+ detach();

Mads Ager (chromium) 2014/07/11 09:15:01 Since the call to detach is not needed in the non-

deleteObject(0);

}