Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1776)

Unified Diff: cc/trees/layer_tree_host_impl.cc

Issue 365463003: Implement scroll handler latency tracking (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review comments. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_impl.cc
diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc
index de1e8ffcacd26e2befe65d392552ba699e0a7b75..624d73fd8977aee8ed069f7a0877fb69b5d7e336 100644
--- a/cc/trees/layer_tree_host_impl.cc
+++ b/cc/trees/layer_tree_host_impl.cc
@@ -500,6 +500,11 @@ LayerTreeHostImpl::CreateLatencyInfoSwapPromiseMonitor(
new LatencyInfoSwapPromiseMonitor(latency, NULL, this));
}
+void LayerTreeHostImpl::QueueScrollUpdateLatencyInfo(
+ const ui::LatencyInfo& latency_info) {
+ scroll_update_latency_infos_.push_back(latency_info);
danakj 2014/07/08 16:49:07 Should we be dropping SwapPromises if the list get
Sami 2014/07/09 13:28:55 Good point, I've added the same logic here.
+}
+
void LayerTreeHostImpl::TrackDamageForAllSurfaces(
LayerImpl* root_draw_layer,
const LayerImplList& render_surface_layer_list) {
@@ -2468,6 +2473,11 @@ bool LayerTreeHostImpl::ScrollBy(const gfx::Point& viewport_point,
bool did_scroll_content = did_scroll_x || did_scroll_y;
if (did_scroll_content) {
+ // If we are scrolling with an active scroll handler, forward latency
+ // tracking information to the main thread so the delay introduced by the
+ // handler is accounted for.
+ if (scroll_affects_scroll_handler())
+ NotifySwapPromiseMonitorsOfForwardingToMainThread();
client_->SetNeedsCommitOnImplThread();
SetNeedsRedraw();
client_->RenewTreePriority();
@@ -2769,6 +2779,7 @@ scoped_ptr<ScrollAndScaleSet> LayerTreeHostImpl::ProcessScrollDeltas() {
CollectScrollDeltas(scroll_info.get(), active_tree_->root_layer());
scroll_info->page_scale_delta = active_tree_->page_scale_delta();
active_tree_->set_sent_page_scale_delta(scroll_info->page_scale_delta);
+ std::swap(scroll_info->latency_infos, scroll_update_latency_infos_);
return scroll_info.Pass();
}
@@ -3145,6 +3156,12 @@ void LayerTreeHostImpl::NotifySwapPromiseMonitorsOfSetNeedsRedraw() {
(*it)->OnSetNeedsRedrawOnImpl();
}
+void LayerTreeHostImpl::NotifySwapPromiseMonitorsOfForwardingToMainThread() {
+ std::set<SwapPromiseMonitor*>::iterator it = swap_promise_monitor_.begin();
+ for (; it != swap_promise_monitor_.end(); it++)
+ (*it)->OnForwardScrollUpdateToMainThreadOnImpl();
+}
+
void LayerTreeHostImpl::RegisterPictureLayerImpl(PictureLayerImpl* layer) {
DCHECK(std::find(picture_layers_.begin(), picture_layers_.end(), layer) ==
picture_layers_.end());

Powered by Google App Engine
This is Rietveld 408576698