Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: cc/trees/layer_tree_host_impl.cc

Issue 365463003: Implement scroll handler latency tracking (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review comments. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/trees/layer_tree_host_impl.h" 5 #include "cc/trees/layer_tree_host_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <limits> 8 #include <limits>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 482 matching lines...) Expand 10 before | Expand all | Expand 10 after
493 return layer_impl != NULL; 493 return layer_impl != NULL;
494 } 494 }
495 495
496 scoped_ptr<SwapPromiseMonitor> 496 scoped_ptr<SwapPromiseMonitor>
497 LayerTreeHostImpl::CreateLatencyInfoSwapPromiseMonitor( 497 LayerTreeHostImpl::CreateLatencyInfoSwapPromiseMonitor(
498 ui::LatencyInfo* latency) { 498 ui::LatencyInfo* latency) {
499 return scoped_ptr<SwapPromiseMonitor>( 499 return scoped_ptr<SwapPromiseMonitor>(
500 new LatencyInfoSwapPromiseMonitor(latency, NULL, this)); 500 new LatencyInfoSwapPromiseMonitor(latency, NULL, this));
501 } 501 }
502 502
503 void LayerTreeHostImpl::QueueScrollUpdateLatencyInfo(
504 const ui::LatencyInfo& latency_info) {
505 scroll_update_latency_infos_.push_back(latency_info);
danakj 2014/07/08 16:49:07 Should we be dropping SwapPromises if the list get
Sami 2014/07/09 13:28:55 Good point, I've added the same logic here.
506 }
507
503 void LayerTreeHostImpl::TrackDamageForAllSurfaces( 508 void LayerTreeHostImpl::TrackDamageForAllSurfaces(
504 LayerImpl* root_draw_layer, 509 LayerImpl* root_draw_layer,
505 const LayerImplList& render_surface_layer_list) { 510 const LayerImplList& render_surface_layer_list) {
506 // For now, we use damage tracking to compute a global scissor. To do this, we 511 // For now, we use damage tracking to compute a global scissor. To do this, we
507 // must compute all damage tracking before drawing anything, so that we know 512 // must compute all damage tracking before drawing anything, so that we know
508 // the root damage rect. The root damage rect is then used to scissor each 513 // the root damage rect. The root damage rect is then used to scissor each
509 // surface. 514 // surface.
510 515
511 for (int surface_index = render_surface_layer_list.size() - 1; 516 for (int surface_index = render_surface_layer_list.size() - 1;
512 surface_index >= 0; 517 surface_index >= 0;
(...skipping 1948 matching lines...) Expand 10 before | Expand all | Expand 10 after
2461 // which the layer moved. 2466 // which the layer moved.
2462 gfx::Vector2dF perpendicular_axis(-applied_delta.y(), applied_delta.x()); 2467 gfx::Vector2dF perpendicular_axis(-applied_delta.y(), applied_delta.x());
2463 pending_delta = MathUtil::ProjectVector(pending_delta, perpendicular_axis); 2468 pending_delta = MathUtil::ProjectVector(pending_delta, perpendicular_axis);
2464 2469
2465 if (gfx::ToRoundedVector2d(pending_delta).IsZero()) 2470 if (gfx::ToRoundedVector2d(pending_delta).IsZero())
2466 break; 2471 break;
2467 } 2472 }
2468 2473
2469 bool did_scroll_content = did_scroll_x || did_scroll_y; 2474 bool did_scroll_content = did_scroll_x || did_scroll_y;
2470 if (did_scroll_content) { 2475 if (did_scroll_content) {
2476 // If we are scrolling with an active scroll handler, forward latency
2477 // tracking information to the main thread so the delay introduced by the
2478 // handler is accounted for.
2479 if (scroll_affects_scroll_handler())
2480 NotifySwapPromiseMonitorsOfForwardingToMainThread();
2471 client_->SetNeedsCommitOnImplThread(); 2481 client_->SetNeedsCommitOnImplThread();
2472 SetNeedsRedraw(); 2482 SetNeedsRedraw();
2473 client_->RenewTreePriority(); 2483 client_->RenewTreePriority();
2474 } 2484 }
2475 2485
2476 // Scrolling along an axis resets accumulated root overscroll for that axis. 2486 // Scrolling along an axis resets accumulated root overscroll for that axis.
2477 if (did_scroll_x) 2487 if (did_scroll_x)
2478 accumulated_root_overscroll_.set_x(0); 2488 accumulated_root_overscroll_.set_x(0);
2479 if (did_scroll_y) 2489 if (did_scroll_y)
2480 accumulated_root_overscroll_.set_y(0); 2490 accumulated_root_overscroll_.set_y(0);
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
2762 for (size_t i = 0; i < layer_impl->children().size(); ++i) 2772 for (size_t i = 0; i < layer_impl->children().size(); ++i)
2763 CollectScrollDeltas(scroll_info, layer_impl->children()[i]); 2773 CollectScrollDeltas(scroll_info, layer_impl->children()[i]);
2764 } 2774 }
2765 2775
2766 scoped_ptr<ScrollAndScaleSet> LayerTreeHostImpl::ProcessScrollDeltas() { 2776 scoped_ptr<ScrollAndScaleSet> LayerTreeHostImpl::ProcessScrollDeltas() {
2767 scoped_ptr<ScrollAndScaleSet> scroll_info(new ScrollAndScaleSet()); 2777 scoped_ptr<ScrollAndScaleSet> scroll_info(new ScrollAndScaleSet());
2768 2778
2769 CollectScrollDeltas(scroll_info.get(), active_tree_->root_layer()); 2779 CollectScrollDeltas(scroll_info.get(), active_tree_->root_layer());
2770 scroll_info->page_scale_delta = active_tree_->page_scale_delta(); 2780 scroll_info->page_scale_delta = active_tree_->page_scale_delta();
2771 active_tree_->set_sent_page_scale_delta(scroll_info->page_scale_delta); 2781 active_tree_->set_sent_page_scale_delta(scroll_info->page_scale_delta);
2782 std::swap(scroll_info->latency_infos, scroll_update_latency_infos_);
2772 2783
2773 return scroll_info.Pass(); 2784 return scroll_info.Pass();
2774 } 2785 }
2775 2786
2776 void LayerTreeHostImpl::SetFullRootLayerDamage() { 2787 void LayerTreeHostImpl::SetFullRootLayerDamage() {
2777 SetViewportDamage(gfx::Rect(DrawViewportSize())); 2788 SetViewportDamage(gfx::Rect(DrawViewportSize()));
2778 } 2789 }
2779 2790
2780 void LayerTreeHostImpl::RunOnDemandRasterTask(Task* on_demand_raster_task) { 2791 void LayerTreeHostImpl::RunOnDemandRasterTask(Task* on_demand_raster_task) {
2781 DCHECK(on_demand_task_graph_runner_); 2792 DCHECK(on_demand_task_graph_runner_);
(...skipping 356 matching lines...) Expand 10 before | Expand all | Expand 10 after
3138 void LayerTreeHostImpl::RemoveSwapPromiseMonitor(SwapPromiseMonitor* monitor) { 3149 void LayerTreeHostImpl::RemoveSwapPromiseMonitor(SwapPromiseMonitor* monitor) {
3139 swap_promise_monitor_.erase(monitor); 3150 swap_promise_monitor_.erase(monitor);
3140 } 3151 }
3141 3152
3142 void LayerTreeHostImpl::NotifySwapPromiseMonitorsOfSetNeedsRedraw() { 3153 void LayerTreeHostImpl::NotifySwapPromiseMonitorsOfSetNeedsRedraw() {
3143 std::set<SwapPromiseMonitor*>::iterator it = swap_promise_monitor_.begin(); 3154 std::set<SwapPromiseMonitor*>::iterator it = swap_promise_monitor_.begin();
3144 for (; it != swap_promise_monitor_.end(); it++) 3155 for (; it != swap_promise_monitor_.end(); it++)
3145 (*it)->OnSetNeedsRedrawOnImpl(); 3156 (*it)->OnSetNeedsRedrawOnImpl();
3146 } 3157 }
3147 3158
3159 void LayerTreeHostImpl::NotifySwapPromiseMonitorsOfForwardingToMainThread() {
3160 std::set<SwapPromiseMonitor*>::iterator it = swap_promise_monitor_.begin();
3161 for (; it != swap_promise_monitor_.end(); it++)
3162 (*it)->OnForwardScrollUpdateToMainThreadOnImpl();
3163 }
3164
3148 void LayerTreeHostImpl::RegisterPictureLayerImpl(PictureLayerImpl* layer) { 3165 void LayerTreeHostImpl::RegisterPictureLayerImpl(PictureLayerImpl* layer) {
3149 DCHECK(std::find(picture_layers_.begin(), picture_layers_.end(), layer) == 3166 DCHECK(std::find(picture_layers_.begin(), picture_layers_.end(), layer) ==
3150 picture_layers_.end()); 3167 picture_layers_.end());
3151 picture_layers_.push_back(layer); 3168 picture_layers_.push_back(layer);
3152 } 3169 }
3153 3170
3154 void LayerTreeHostImpl::UnregisterPictureLayerImpl(PictureLayerImpl* layer) { 3171 void LayerTreeHostImpl::UnregisterPictureLayerImpl(PictureLayerImpl* layer) {
3155 std::vector<PictureLayerImpl*>::iterator it = 3172 std::vector<PictureLayerImpl*>::iterator it =
3156 std::find(picture_layers_.begin(), picture_layers_.end(), layer); 3173 std::find(picture_layers_.begin(), picture_layers_.end(), layer);
3157 DCHECK(it != picture_layers_.end()); 3174 DCHECK(it != picture_layers_.end());
3158 picture_layers_.erase(it); 3175 picture_layers_.erase(it);
3159 } 3176 }
3160 3177
3161 } // namespace cc 3178 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698